Remove package table from release blogposts #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
documentation
and removed
needs label triage
cmdcolin
commented
May 9, 2023
| # Generates a changelog with a section added listing the packages that were | ||
| # included in this release | ||
| CHANGELOG=$(GITHUB_AUTH="$GITHUB_AUTH" node scripts/changelog.js "$CHANGED" "$VERSION") |
There was a problem hiding this comment.
I believe this will effectively output the same thing
|
might go ahead with merge...can review if there are concerns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a website proposal to remove the 'package table' from release blogposts. They are generally a little confusing, and we publish every single package on every release now, so it seems like they may not be needed. They also report things like e.g. that trix was updated when it wasn't really. Not sure how it gets that exactly (sometimes you can see this in the actual changelog that gets outputted too, it automatically categorizes each PR to a package but it sometimes reports this as some unrelated package).
Example of the package table I propose removing
https://jbrowse.org/jb2/blog/2023/05/04/v2.5.0-release/#250-2023-05-04