-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix centering of the ImportForm on SV inspector #3713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
May 19, 2023
cmdcolin
changed the title
Fix importform layout
Fix centering of the ImportForm on SV inspector
May 19, 2023
cmdcolin
added
bug
Something isn't working
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
May 19, 2023
this one is hard to 'test for' without perhaps doing a puppeteer screenshot, but that could be interesting perhaps |
original issue that introduced regression #3610 |
Codecov Report
@@ Coverage Diff @@
## main #3713 +/- ##
==========================================
- Coverage 64.24% 64.21% -0.03%
==========================================
Files 934 937 +3
Lines 29996 29986 -10
Branches 7265 7256 -9
==========================================
- Hits 19271 19257 -14
- Misses 10560 10564 +4
Partials 165 165
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
force-pushed
the
fix_importform_layout
branch
from
May 19, 2023 19:29
641a13b
to
a3c2126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.4.2 introduced a regression where the SV inspector import form layout was not centered
This fixes that, and provides a couple of CSS style refactors
current main
this branch
also fixes an issue with "Open split view" not properly showing a disabled state when the features are not TRA/BND events