Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix centering of the ImportForm on SV inspector #3713

Merged
merged 6 commits into from
May 19, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented May 19, 2023

v2.4.2 introduced a regression where the SV inspector import form layout was not centered

This fixes that, and provides a couple of CSS style refactors

current main
image

this branch
image

also fixes an issue with "Open split view" not properly showing a disabled state when the features are not TRA/BND events

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 19, 2023
@cmdcolin cmdcolin changed the title Fix importform layout Fix centering of the ImportForm on SV inspector May 19, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 19, 2023
@cmdcolin
Copy link
Collaborator Author

this one is hard to 'test for' without perhaps doing a puppeteer screenshot, but that could be interesting perhaps

@cmdcolin
Copy link
Collaborator Author

original issue that introduced regression #3610

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #3713 (641a13b) into main (3ef1ed1) will decrease coverage by 0.03%.
The diff coverage is 62.74%.

@@            Coverage Diff             @@
##             main    #3713      +/-   ##
==========================================
- Coverage   64.24%   64.21%   -0.03%     
==========================================
  Files         934      937       +3     
  Lines       29996    29986      -10     
  Branches     7265     7256       -9     
==========================================
- Hits        19271    19257      -14     
- Misses      10560    10564       +4     
  Partials      165      165              
Impacted Files Coverage Δ
packages/app-core/src/ui/ViewContainer.tsx 83.33% <ø> (ø)
...iew/src/BreakpointSplitView/BreakpointSplitView.ts 72.34% <0.00%> (+2.95%) ⬆️
...src/SvInspectorView/components/SvInspectorView.tsx 66.66% <ø> (-6.07%) ⬇️
...src/SpreadsheetView/components/RowCountMessage.tsx 52.94% <52.94%> (ø)
...-view/src/SpreadsheetView/components/StatusBar.tsx 57.14% <57.14%> (ø)
...view/src/SpreadsheetView/models/SpreadsheetView.ts 65.62% <75.00%> (+0.62%) ⬆️
...ctor/src/SvInspectorView/models/SvInspectorView.ts 70.94% <75.00%> (+0.14%) ⬆️
...SvInspectorView/components/CircularViewOptions.tsx 83.33% <83.33%> (ø)
...src/SpreadsheetView/components/SpreadsheetView.tsx 88.00% <100.00%> (+14.47%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin force-pushed the fix_importform_layout branch from 641a13b to a3c2126 Compare May 19, 2023 19:29
@cmdcolin cmdcolin merged commit 6703c7a into main May 19, 2023
@cmdcolin cmdcolin deleted the fix_importform_layout branch May 19, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant