Fix specifying the assemblyNames config slot on add-connection CLI #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
commented
May 31, 2023
|
|
||
| let configObj = {} | ||
| if (config) { | ||
| try { | ||
| configObj = parseJSON(config) |
There was a problem hiding this comment.
try catch removed to get the better json error message from package we import
cmdcolin
changed the title
cmdcolin
added
bug
cmdcolin
force-pushed
the
add-connection-cli
branch
from
3d33542 to
90d4f12
Compare
Codecov Report
@@ Coverage Diff @@
## main #3739 +/- ##
==========================================
- Coverage 64.39% 64.39% -0.01%
==========================================
Files 963 963
Lines 29925 29905 -20
Branches 7182 7174 -8
==========================================
- Hits 19270 19256 -14
+ Misses 10489 10483 -6
Partials 166 166
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames --assemblyName to --assemblyNames in the add-connection CLI, and makes clear that it is optional and is a comma separated list of multiple assembly names
Also makes some miscellaneous code simplifications