Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential issue with display searchFeatureByID being undefined #3770

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 28, 2023

Issue found by @carolinebridge-oicr

Created when toggling the display type on an alignments track to e.g. arc display

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 28, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #3770 (8186246) into main (a9a64d5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3770   +/-   ##
=======================================
  Coverage   64.10%   64.10%           
=======================================
  Files         987      987           
  Lines       29664    29664           
  Branches     7094     7094           
=======================================
  Hits        19016    19016           
  Misses      10484    10484           
  Partials      164      164           
Impacted Files Coverage Δ
...ments/src/LinearAlignmentsDisplay/models/model.tsx 78.68% <100.00%> (ø)
...kpoint-split-view/src/BreakpointSplitView/model.ts 75.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 8b89616 into main Jun 29, 2023
@cmdcolin cmdcolin deleted the fix_alignments_display_breakpointsplitview branch June 29, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant