Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on color picker component using debounce on color property #3782

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

carolinebridge
Copy link
Contributor

@carolinebridge carolinebridge commented Jul 4, 2023

^ title, pretty simple fix for #3763

@carolinebridge carolinebridge requested a review from cmdcolin July 4, 2023 20:18
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 4, 2023
@carolinebridge carolinebridge added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #3782 (c0c8cf7) into main (a45f111) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3782      +/-   ##
==========================================
- Coverage   64.26%   64.25%   -0.02%     
==========================================
  Files         987      987              
  Lines       29667    29668       +1     
  Branches     7096     7096              
==========================================
- Hits        19066    19062       -4     
- Misses      10437    10442       +5     
  Partials      164      164              
Impacted Files Coverage Δ
packages/core/ui/ColorPicker.tsx 26.66% <0.00%> (-0.92%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit b5371a8 into main Jul 4, 2023
@cmdcolin cmdcolin deleted the fix-crash-color-picker branch July 4, 2023 22:27
@cmdcolin
Copy link
Collaborator

cmdcolin commented Jul 4, 2023

excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants