Centralize rpcWorker in product-core #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
|
See #3785 for xref'd fetchCJS issue |
cmdcolin
added
internal
and removed
needs label triage
cmdcolin
force-pushed
the
centralize_rpc
branch
2 times, most recently
from
948b000 to
28dbc74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces some code duplication across packages
Also updates serialize-error by async importing the esm (which works in cjs land)
I also noticed a possible bug where the 'fetchCJS' callback on desktop was not available from the worker. I did not add this to this PR as I do observe that the 'fetchCJS' concept was using window.require which I'm not sure is available on web worker. If there is a cjs plugin for testing could from a URL was not available on desktop in the worker, but I don't have any mechanism of truly testing this