Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suspense fallback to track container for lazy loaded display components #3814

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix suspense fallback to track container for lazy loaded display components #3814

merged 1 commit into from
Jul 17, 2023

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3802

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #3814 (1f75b53) into main (1d300b0) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3814      +/-   ##
==========================================
+ Coverage   64.42%   64.43%   +0.01%     
==========================================
  Files         992      992              
  Lines       29552    29552              
  Branches     7082     7082              
==========================================
+ Hits        19038    19042       +4     
+ Misses      10353    10349       -4     
  Partials      161      161
Impacted Files Coverage Δ
...rGenomeView/components/TrackRenderingContainer.tsx 86.36% <ø> (ø)
...iggleDisplay/components/WiggleDisplayComponent.tsx 91.66% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 17, 2023
@cmdcolin cmdcolin merged commit e659724 into main Jul 17, 2023
@cmdcolin cmdcolin deleted the add_suspense_display branch July 17, 2023 18:00
@cmdcolin cmdcolin mentioned this pull request Jul 19, 2023
Merged
@cmdcolin cmdcolin changed the title Add suspense fallback to track container for lazy loaded display components Fix suspense fallback to track container for lazy loaded display components Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening MultiBigWig track makes LGV blink a Loading state
1 participant
@cmdcolin