Refactors LGV synteny and pileup with shared mixins #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carolinebridge
commented
Jul 24, 2023
carolinebridge
commented
- fixes a loading issue when changing the colouration type
- refactor for inherited features for pileup display on synteny display
…e that is selected by user
…rsistence on refresh
…nto a Mixin (#3781) * separating out shared functionality into a mixin for pileup and synteny to inherit separately with their own implementations * fixing lint with strict typing * mv interface to shared file and add maybe type back * revert change to package.json
cmdcolin
force-pushed
the
lgv-synteny-color2
branch
from
171127f to
9938498
Compare
cmdcolin
force-pushed
the
lgv-synteny-color2
branch
from
9938498 to
aa1d6c8
Compare
|
had some failing tests for "sort by" and "show soft clip", added some fixes for that and should be ok now though. shows the benefit of those integration tests though. would be nice if those integration tests were faster or there were ways to make it more unit-y since the integration tests just are a bit slow |
|
yeah i actually caught the exact same thing right as you pushed your change lmao -- the testing suite being so clunky (and also the unreliability of failing tests via timeout) definitely makes the process take longer to debug. |
Codecov Report
@@ Coverage Diff @@
## main #3830 +/- ##
==========================================
+ Coverage 64.35% 64.39% +0.04%
==========================================
Files 998 999 +1
Lines 29656 29707 +51
Branches 7116 7125 +9
==========================================
+ Hits 19084 19131 +47
- Misses 10411 10414 +3
- Partials 161 162 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.