-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds keyboard shortcuts for panning and zooming on a focused view #3832
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3832 +/- ##
==========================================
+ Coverage 64.45% 64.47% +0.02%
==========================================
Files 1003 1003
Lines 29782 29799 +17
Branches 7146 7151 +5
==========================================
+ Hits 19196 19213 +17
Misses 10423 10423
Partials 163 163
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
i might agree with ctrl+up/down because we have ctrl+scroll for zoom too |
Added ctrl/meta keys to the left and right operations --
|
…olors infocus view secondary.light palette, and outfocus view secondary.dark
…perations; added preventdefault
4da760a
to
f372736
Compare
I added a 'removeEventHandler' using an addDisposer. I think should be good to go. it is a little tricky, becuase I was pressing "ctrl+down" multiple times but it would not zoom out a lot. that is because it is actively doing an animation. it may be good to find a workaround for this...i think it would be good to 'quickly zoom out' a multiple rapid ctrl+down key presses. |
might not be necessary to hold up the PR though. can merge :) |
Adds keyboard shortcuts for:
Scroll with LeftArrow and RightArrow
Zoom with Shift + (UpArrow || DownArrow)
Waiting for the focus PR to be merged before this one into main
Partially resolves #927