-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eject react-script config from jbrowse-web and jbrowse-desktop #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Aug 29, 2023
cmdcolin
added
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Aug 29, 2023
cmdcolin
force-pushed
the
webpack_eject3
branch
2 times, most recently
from
August 29, 2023 20:53
d4ab6e4
to
6286b67
Compare
Codecov Report
@@ Coverage Diff @@
## main #3885 +/- ##
==========================================
- Coverage 64.45% 64.42% -0.04%
==========================================
Files 1004 1004
Lines 29809 29789 -20
Branches 7154 7143 -11
==========================================
- Hits 19214 19191 -23
- Misses 10429 10432 +3
Partials 166 166
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
force-pushed
the
webpack_eject3
branch
from
August 29, 2023 21:52
6286b67
to
d0ae041
Compare
cmdcolin
force-pushed
the
webpack_eject3
branch
from
August 29, 2023 23:01
c444d77
to
83ea404
Compare
cmdcolin
force-pushed
the
webpack_eject3
branch
from
August 29, 2023 23:26
83ea404
to
63bf68c
Compare
cmdcolin
changed the title
Eject react-script config v2
Eject react-script config from jbrowse-web and jbrowse-desktop
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a less heavy handed approach to #3852
We can try to reduce amount of config over time, but that PR aggressively tried to prune the amount of webpack config. This PR is comparatively more similar to "just running react-scripts eject" and keeping the result