Fix ability to use plaintext bed in add-track CLI #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
commented
Sep 7, 2023
| return { | ||
| type: 'UNSUPPORTED', | ||
| } | ||
| } | ||
|
|
||
| if (/\.bed$/i.test(location)) { |
There was a problem hiding this comment.
There were two checks for .bed$, first here, saying UNSUPPORTED
cmdcolin
commented
Sep 7, 2023
| @@ -547,116 +518,81 @@ export default class AddTrack extends JBrowseCommand { | |||
| indexType: index?.toUpperCase().endsWith('CSI') ? 'CSI' : 'TBI', | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| if (/\.bed$/i.test(location)) { | |||
cmdcolin
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #3902 +/- ##
==========================================
- Coverage 64.49% 64.49% -0.01%
==========================================
Files 1004 1004
Lines 29804 29803 -1
Branches 7143 7143
==========================================
- Hits 19222 19220 -2
- Misses 10417 10418 +1
Partials 165 165
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
changed the title
cmdcolin
added
bug
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.