Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignments track infinite loading when applying same "Color by" or "Sort by" setting twice #3905

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Sep 8, 2023

Current main branch has a bug where applying e.g. "Color by"->"Tag" (select HP) or similarly "Sort by"->"Tag" (select HP) twice results in it hanging the second time

This is because it sets "sortReady:false", but the autorun does not detect that the "sortedBy" structure has changed since it is the same, so it doesn't change. This makes the autorun also listen for !sortReady (an analogous setting+autorun for colorBy)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 8, 2023
@cmdcolin cmdcolin changed the title Fix pileup display infinite loading when applying same "Color by" or "Sort by" setting twice Fix alignments track infinite loading when applying same "Color by" or "Sort by" setting twice Sep 8, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 8, 2023
@cmdcolin cmdcolin force-pushed the fix_pileup_display_sortby_hang branch from 90cc2f7 to 5637746 Compare September 8, 2023 16:43
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #3905 (5637746) into main (5a04508) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##             main    #3905   +/-   ##
=======================================
  Coverage   64.49%   64.49%           
=======================================
  Files        1004     1004           
  Lines       29809    29811    +2     
  Branches     7145     7147    +2     
=======================================
+ Hits        19226    19228    +2     
  Misses      10418    10418           
  Partials      165      165           
Files Changed Coverage Δ
plugins/alignments/src/PileupRenderer/colorBy.ts 41.66% <0.00%> (ø)
...earPileupDisplay/SharedLinearPileupDisplayMixin.ts 72.10% <100.00%> (ø)
...lugins/alignments/src/LinearPileupDisplay/model.ts 82.11% <100.00%> (+0.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit f262779 into main Sep 8, 2023
@cmdcolin cmdcolin deleted the fix_pileup_display_sortby_hang branch September 8, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant