-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds code improvements to GridBookmarkWidget #3938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Sep 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #3938 +/- ##
==========================================
- Coverage 64.04% 63.71% -0.34%
==========================================
Files 1013 1018 +5
Lines 30177 30189 +12
Branches 7195 7200 +5
==========================================
- Hits 19327 19235 -92
- Misses 10687 10790 +103
- Partials 163 164 +1
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
carolinebridge
added
enhancement
New feature or request
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Sep 20, 2023
carolinebridge
changed the title
adding changes from grid_mods
Adds code improves to GridBookmarkWidget
Sep 20, 2023
carolinebridge
changed the title
Adds code improves to GridBookmarkWidget
Adds code improvements to GridBookmarkWidget
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages work done by @cmdcolin from #3932
Accepts most recommended changes to code styling while fixing bugs and preserving functionality.
Summary of changes: