-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors for app-core view container #3994
Conversation
9f91a49
to
47cfde7
Compare
f41e6d6
to
e8e8f5f
Compare
Per #3860 I was thinking we could satisfy the "view is unfocused when you create it / it's the last one after you delete a different view" by making the focused view automatically swap to the last remaining view when there's only one.
|
e8e8f5f
to
82728c0
Compare
@carolinebridge-oicr I didn't properly write up a description for this PR. and, unfortunately, I cannot generate a good repro, but I was seeing that clicking in certain places in e.g. a plain old LGV would not focus that LGV. This may have been a fluke or something else. This PR is now is basically just miscellaneous refactoring as a result |
82728c0
to
8fb75b2
Compare
6da6bf0
to
8a94948
Compare
8a94948
to
df4a243
Compare
Edit: original purpose of this PR was removed, now just refactors