Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors for app-core view container #3994

Merged
merged 8 commits into from
Oct 20, 2023
Merged

Refactors for app-core view container #3994

merged 8 commits into from
Oct 20, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Oct 19, 2023

Edit: original purpose of this PR was removed, now just refactors

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 19, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 19, 2023
@carolinebridge
Copy link
Contributor

Per #3860 I was thinking we could satisfy the "view is unfocused when you create it / it's the last one after you delete a different view" by making the focused view automatically swap to the last remaining view when there's only one.

  • when the user opens a new view, that view becomes the focus (this seems to make sense that if a user is opening a new view they will want that to be their current focus)
  • when a user removes view 2, and view 1 is the last view, that becomes the focus (because there's only one view remaining)

@cmdcolin
Copy link
Collaborator Author

@carolinebridge-oicr I didn't properly write up a description for this PR. and, unfortunately, I cannot generate a good repro, but I was seeing that clicking in certain places in e.g. a plain old LGV would not focus that LGV. This may have been a fluke or something else. This PR is now is basically just miscellaneous refactoring as a result

@cmdcolin cmdcolin changed the title Set focused view on view click Misc refactors for view container Oct 20, 2023
@cmdcolin cmdcolin merged commit 400b77c into main Oct 20, 2023
11 checks passed
@cmdcolin cmdcolin deleted the misc_focus_view branch October 20, 2023 20:50
@cmdcolin cmdcolin changed the title Misc refactors for view container Refactors for app-core view container Oct 20, 2023
cmdcolin added a commit that referenced this pull request Oct 23, 2023
@cmdcolin cmdcolin added internal and removed enhancement New feature or request labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants