-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create multi-region arc display type for variant tracks #4045
Conversation
note that even the regular LinearArcDisplay may benefit from being main-thread multi-region renderer capable. for example, if we do collapse introns, and have a junctions.bed connecting introns, then the arcs will not have 'discontinuities' |
Codecov Report
@@ Coverage Diff @@
## main #4045 +/- ##
==========================================
- Coverage 63.63% 63.23% -0.40%
==========================================
Files 1033 1044 +11
Lines 30319 30534 +215
Branches 7224 7271 +47
==========================================
+ Hits 19293 19308 +15
- Misses 10855 11055 +200
Partials 171 171
... and 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, don't see any usability issues.
Random thoughts:
- i can't find the ticket, but i'm reminded of an idea suggested awhile back to add tooltips / info / context to certain actions like picking a display type that might not show a helpful view depending on the data provided
- we have "zoom in to see data"... what about "zoom out to see data"? the arc view seems to shine when zoomed all the way out, maybe a prompt to inform the user the visualization might be enhanced if they zoom out? is there a use case for that?
- do we have enough discoverability in our documentation for cross-regional visualizations / data rendering? we've got a ton of support for it at this point might be worth having a dedicated page for it in our user guide
yep I think it's #3854 probably still a good endeavor
possibly ya...two sort of related ideas could be a) right clicking an arc, then select "Zoom to feature" (jbrowse 1 actually had a zoom to feature style right click) and b) "Zoom in on the ends of feature in split view" or something like this, where it just creates a multi-region view focused on the ends of the feature, which could help to visualize large deletions or other SVs...
yes could be worthwhile, or at least expanding documentation around the features that use this mode |
BEDPE tracks were already specified as "VariantTrack" in the "guessTrackType extension point" so the add-track CLI addition is 'copasetic' :) |
This adds a new display type LinearPairedArcDisplay, that is main thread rendered, which has generally been useful for creating multi-region displays (hard to do multi-region with the current block based track types)
Summary
jbrowse add-track
<BND>
,<TRA>
, and long features like<DEL>,<INV>,etc.
example screenshot on volvox
fixes #3790
fixes #2548 (somewhat fix, this PR makes new display type specific to variant arcs for this, but this may be the most common reason for multi-region arcs)