Fix issue where --load inPlace and --force can sometimes remove file unexpectedly #4086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is code that will forcibly remove the file at the destination before doing the copy/move/symlink
This is due to a older bug #2768
Unfortunately it has a weird side effect where --load inPlace and --force in combination, if the file path is a valid one (inPlace does not always require valid file paths), it will then remove that file
this is bad behavior, and so this PR fixes it to not forcibly remove the file when load inPlace is used. It could probably additionally narrow it beyond this to only remove when load symlink is used, as copy and move may not be affected by the need to fs.unlink as #2768 brought up