-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor faceted track selector to use more MST state #4094
Conversation
6e5e013
to
7fdd2e7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4094 +/- ##
==========================================
+ Coverage 63.24% 63.35% +0.10%
==========================================
Files 1045 1046 +1
Lines 30616 30653 +37
Branches 7314 7323 +9
==========================================
+ Hits 19362 19419 +57
+ Misses 11084 11062 -22
- Partials 170 172 +2 ☔ View full report in Codecov by Sentry. |
7fdd2e7
to
fd08900
Compare
I think this PR is still a good approach but there is a small bug where if you hide a column, it then resets the widths for all columns after that. hard to fix properly, so will put this PR in draft, and make a new one... |
actually, interestingly, the current main branch has the same bug (it resets the widths after you hide a column) so this is not necessarily a regression on this branch....still would be good to fix but this branch could go forward |
fd08900
to
326dff9
Compare
326dff9
to
69fce71
Compare
The current faceted track selector uses mostly react hooks (and quite a few of them, useMemo, useReducer, useState, useEffect, prop drilling the useReducer/useState callbacks to multiple components, etc.) to try to synchronize relatively complex state. This changes it to mobx-state-tree which has a number of simplifying effects IMO