Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors and bundle size improvements #4107

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Refactors and bundle size improvements #4107

merged 1 commit into from
Dec 1, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 1, 2023

Fairly small misc PR

  • bundle size improvements
  • adds more autogen docs for e.g. joblistwidget, lollipop display

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 1, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2cec283) 63.37% compared to head (3cb1cbf) 63.47%.

Files Patch % Lines
...ins/jobs-management/src/JobsListWidget/jobModel.ts 10.00% 9 Missing ⚠️
...lugins/jobs-management/src/JobsListWidget/index.ts 75.00% 1 Missing ⚠️
...gins/wiggle/src/MultiWiggleAddTrackWidget/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4107      +/-   ##
==========================================
+ Coverage   63.37%   63.47%   +0.09%     
==========================================
  Files        1054     1057       +3     
  Lines       30732    30746      +14     
  Branches     7334     7334              
==========================================
+ Hits        19477    19515      +38     
+ Misses      11086    11059      -27     
- Partials      169      172       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 1, 2023

might save 10-15kb...small but, hopefully helps

@cmdcolin cmdcolin merged commit 73caf57 into main Dec 1, 2023
11 checks passed
@cmdcolin cmdcolin deleted the smaller_bundle3 branch December 1, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant