Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internet accounts not being shown in file selector after page refresh and hide HTTP basic internet accounts #4125

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

cmdcolin
Copy link
Collaborator

Fixes #4122
Fixes #2743

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (8d445a9) 63.40% compared to head (43c6939) 63.40%.

Files Patch % Lines
packages/core/ui/FileSelector/FileSelector.tsx 41.66% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4125      +/-   ##
==========================================
- Coverage   63.40%   63.40%   -0.01%     
==========================================
  Files        1057     1057              
  Lines       30779    30787       +8     
  Branches     7330     7332       +2     
==========================================
+ Hits        19516    19520       +4     
- Misses      11090    11094       +4     
  Partials      173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit 9f69cb5 into main Dec 11, 2023
10 checks passed
@cmdcolin cmdcolin deleted the fix_internet_account branch December 11, 2023 03:46
@cmdcolin cmdcolin added the bug Something isn't working label Dec 15, 2023
@cmdcolin cmdcolin changed the title Fix internet accounts not being shown in FileSelector on page refresh Fix internet accounts not being shown in FileSelector on page refresh and hide HTTP basic internet accounts Dec 15, 2023
@cmdcolin cmdcolin changed the title Fix internet accounts not being shown in FileSelector on page refresh and hide HTTP basic internet accounts Fix internet accounts not being shown in file selector after page refresh and hide HTTP basic internet accounts Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant