Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading plaintext GFF3 files larger than 512Mb #4406

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented May 30, 2024

Uses line-by-line parsing of the Buffer object instead of upfront conversion to the string to avoid the 512Mb string limitation (Buffer can be longer than 512Mb). It also reports the progress with statusCallback which gives some indication of what is happening during possibly long (e.g. 30+ second) loading of larger files

fixes #4403

@cmdcolin cmdcolin changed the title Allow loading plaintext GFF3 buffer larger than 512Mb files Allow loading plaintext GFF3 files larger than 512Mb May 30, 2024
@cmdcolin cmdcolin merged commit ca9d912 into main May 30, 2024
10 checks passed
@cmdcolin cmdcolin deleted the gff3_adapter branch May 30, 2024 14:11
@cmdcolin cmdcolin added the enhancement New feature or request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support plaintext GFF3 greater than 512Mb
1 participant