Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add biome lint fixes #4510

Merged
merged 26 commits into from
Aug 8, 2024
Merged

Add biome lint fixes #4510

merged 26 commits into from
Aug 8, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Aug 5, 2024

This addresses some things flagged from the biome linter (https://biomejs.dev/linter/). it doesn't yet add biome to the CI, but that could be a next step. there are many valid things it triggers on. in particular it was good at catching:

  • usage of implicit any types in typescript, especially when it is supposed to be 'inferred from usage' but wasn't really
  • better exhaustive deps rule for react hooks (compared to eslint exhaustive deps rule)
  • caught some missing eqeqeq (triple ===)
  • caught some usage of index in react key, which is needed in some of our cases, but can be done better (adding something in addition to the idx is often good)
  • changed more things to use template strings instead of string addition

@cmdcolin cmdcolin force-pushed the biome branch 2 times, most recently from 9a6b0f4 to 9df16a9 Compare August 7, 2024 19:30
@cmdcolin cmdcolin force-pushed the biome branch 4 times, most recently from 6e41d45 to f19decb Compare August 8, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant