Create BaseTooltip component in @jbrowse/core/ui #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
tooltip_0coord_workaround
branch
4 times, most recently
from
bcb2bde to
648d4f9
Compare
Use BaseTooltip Shorten build names
cmdcolin
force-pushed
the
tooltip_0coord_workaround
branch
from
648d4f9 to
f19ad87
Compare
cmdcolin
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logic for making tooltips at arbitrary coordinates is copied/pasted in various places. this PR makes a central tooltip component called @jbrowse/core/ui/BaseTooltip, so there is less duplication.
This PR also creates a workaround to an issue where that tooltip would flash at the upper left of screen.
Note that we use this custom tooltip component instead of a @mui/material/Tooltip because the MUI tooltip really wants to wrap an actual element on the page, even the virtual element example wraps an element that is on the page https://mui.com/material-ui/react-tooltip/)