Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing plaintext gff/vcf on desktop #4580

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

cmdcolin
Copy link
Collaborator

There was an invalid assumption that plaintext Gff3Adapter would have the file under the gffGzLocation key

Technically, to solve this issue further we should really

  • find a way to further typescript config objects
  • unify @jbrowse/cli and desktop text indexing code

@cmdcolin cmdcolin added the bug Something isn't working label Sep 19, 2024
@cmdcolin cmdcolin force-pushed the fix_plaintext_indexing_desktop branch from 8740496 to f3d9323 Compare September 19, 2024 17:07
@cmdcolin cmdcolin merged commit 6a1fc5b into main Sep 19, 2024
4 checks passed
@cmdcolin cmdcolin deleted the fix_plaintext_indexing_desktop branch September 19, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant