Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce re-rendering on quantitative and snpcoverage track height adjustments #4652

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

cmdcolin
Copy link
Collaborator

this basically fixes #1730

changing a wiggle track height/snpcov track height would trigger the code to recalculate the stats on the track. this is unnecessary as all it needs to do is redraw

part of the reason for this is that the 'renderProps' variable was being passed to the "WiggleGetMultiRegionQuantitativeStats" RPC

as the name suggests, renderProps are things meant for rendering, but wiggle re-purposed the renderProps to contain the 'filters' for e.g. different BAM/CRAM flags, but the renderProps contains track height also, so the stats calculation autorun would re-run repeatedly on track height changes

I separated out a parameter called 'adapterProps' that helps with this. The concept of adapterProps isn't extensively distributed through the codebase but it does help with this case

@cmdcolin cmdcolin changed the title Reduce re-rendering on quantitative track height adjustments Reduce re-rendering on quantitative and snpcoverage track height adjustments Nov 13, 2024
@cmdcolin cmdcolin force-pushed the zoom_level_stat branch 2 times, most recently from 83ccfdd to b8dabb1 Compare November 13, 2024 08:32
@cmdcolin cmdcolin merged commit 24f972c into main Nov 13, 2024
4 checks passed
@cmdcolin cmdcolin deleted the zoom_level_stat branch November 13, 2024 08:45
@cmdcolin cmdcolin added the enhancement New feature or request label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing track height with click and drag rapidly produces re-rendering requests
1 participant