Reduce re-rendering on quantitative and snpcoverage track height adjustments #4652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this basically fixes #1730
changing a wiggle track height/snpcov track height would trigger the code to recalculate the stats on the track. this is unnecessary as all it needs to do is redraw
part of the reason for this is that the 'renderProps' variable was being passed to the "WiggleGetMultiRegionQuantitativeStats" RPC
as the name suggests, renderProps are things meant for rendering, but wiggle re-purposed the renderProps to contain the 'filters' for e.g. different BAM/CRAM flags, but the renderProps contains track height also, so the stats calculation autorun would re-run repeatedly on track height changes
I separated out a parameter called 'adapterProps' that helps with this. The concept of adapterProps isn't extensively distributed through the codebase but it does help with this case