Avoid full length sequence fetch on SNP coverage calculation #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #4647 which addressed primarily rendering modifications made a large number of refactors to make rendering modifications and methylation improved
In the process it introduced a change that fetched the entire sequence. However, there are some cases where
a) jbrowse will decide to render when you are zoomed out super far (for e.g. targetted sequencing)
b) then it will fetch an entire chromosomes worth of data
there is an additional thing where maybe there is something else combining the requests because the indexedfastaadapter is designed to break up requests into smaller chunks, but a user was observing that it was making a single(?) huge HTTP Range request and this was rejected by google cloud servers