Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deals with ACLs #1558

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Deals with ACLs #1558

wants to merge 1 commit into from

Conversation

FredericBGA
Copy link
Contributor

-d and -w test operators do not seem to respect the acls. use filetest pragma

@rbuels
Copy link
Collaborator

rbuels commented Dec 1, 2020

@FredericBGA will this affect the minimum version of Perl that the tools require?

@cmdcolin
Copy link
Contributor

cmdcolin commented Dec 1, 2020

this also is only applied to IndexNames e.g. generate-names...is it something that needs distributing more widely?

more reading on filetest here https://perldoc.perl.org/filetest

@cmdcolin
Copy link
Contributor

cmdcolin commented Dec 1, 2020

I also wonder: what was the error before this change was added? Was it unable to write things it should have been able to write to?

@FredericBGA
Copy link
Contributor Author

The error was:

Output directory '.' is not writable.
at /softs/bioinfo/jbrowse-1.16.10-release/bin/../src/perl5/Bio/JBrowse/ConfigurationManager.pm line 7.
Bio::JBrowse::ConfigurationManager::ANON("Output directory '.' is not writable.\x{a}") called at /softs/bioinfo/jbrowse-1.16
.10-release/bin/../src/perl5/Bio/JBrowse/Cmd/IndexNames.pm line 73
Bio::JBrowse::Cmd::IndexNames::run(Bio::JBrowse::Cmd::IndexNames=HASH(0x2624f30)) called at /softs/bioinfo/jbrowse/bin/generate-
names.pl line 8

but the directory was indeed writable due to ALCs.
I don't know if this should be applied more widely. We use JBrowse a lot and we didn't notice anything else that looks related.
Regarding the Perl minimun version, I don't know... We have v5.10.1.
filetest seems to exist since Perl 5.6.0: https://metacpan.org/pod/release/GSAR/perl-5.6.0/lib/filetest.pm

@cmdcolin
Copy link
Contributor

cmdcolin commented Dec 2, 2020

seems like this should be ok. it does say in the docs here https://perldoc.perl.org/filetest to consider this carefully, but if it helps and doesn't have side effects then it seems good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants