Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to newer version of Doctrine (2.5 at least) #335

Closed
GRyall opened this issue Feb 16, 2022 · 6 comments · May be fixed by #455
Closed

Move to newer version of Doctrine (2.5 at least) #335

GRyall opened this issue Feb 16, 2022 · 6 comments · May be fixed by #455
Labels
enhancement hackathon Issues that could be solved within a day

Comments

@GRyall
Copy link
Contributor

GRyall commented Feb 16, 2022

The version of Doctrine we currently use is no longer supported (https://www.doctrine-project.org/projects/orm.html). We were stuck on it because the next version (2.5) required php 5.4 or greater. With #238 we removed php 5.3 support and so can now migrate upwards. This may be true for other components as well.

Pretty careful testing would be needed

@gregcorbett gregcorbett changed the title Evaluate move to newer version of Doctrine and other components Move to newer version of Doctrine (2.5 at least) Feb 17, 2022
@gregcorbett
Copy link
Member

subject to careful testing, this could be a quick win.

@gregcorbett gregcorbett added the hackathon Issues that could be solved within a day label Feb 17, 2022
@gregcorbett gregcorbett added this to the August 2022 milestone Feb 17, 2022
@gregcorbett
Copy link
Member

The dream would be going all the way to 2.12

@gregcorbett gregcorbett mentioned this issue Feb 17, 2022
4 tasks
@gregcorbett gregcorbett assigned ghost Mar 15, 2022
@ghost
Copy link

ghost commented Apr 5, 2022

@GRyall

Pretty careful testing would be needed

Beyond the 'unit' tests, checking some arbitrary functionality through the web+PI interfaces, and looking for errors/warnings in logfiles, do you have suggestions for what else 'Pretty careful' might mean in this context? (ORM update to 2.5.14 appears, at first glance, to be unproblematic.)

@ghost ghost mentioned this issue May 10, 2022
@gregcorbett gregcorbett modified the milestones: August 2022, November 2022 Sep 6, 2022
@gregcorbett gregcorbett modified the milestones: November 2022, June 2023 Nov 2, 2022
@GRyall
Copy link
Contributor Author

GRyall commented Feb 6, 2023

@GRyall

Pretty careful testing would be needed

Beyond the 'unit' tests, checking some arbitrary functionality through the web+PI interfaces, and looking for errors/warnings in logfiles, do you have suggestions for what else 'Pretty careful' might mean in this context? (ORM update to 2.5.14 appears, at first glance, to be unproblematic.)

Mainly I meant "checking some arbitrary functionality through the web+PI interfaces"

@gregcorbett
Copy link
Member

We are running ORM 2.6, getting to a supported version is tracked in #337

@GRyall
Copy link
Contributor Author

GRyall commented Sep 12, 2024

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hackathon Issues that could be solved within a day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants