Remove php5.3 support #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRyall
force-pushed
the
removePhp5.3
branch
3 times, most recently
from
53236a3 to
578f2f1
Compare
|
I'll move this out of draft once #190 is merged. We won't want to merge it until SL6 is EOL and we no longer support php 5.3 |
GRyall
force-pushed
the
removePhp5.3
branch
2 times, most recently
from
af30847 to
620898c
Compare
php 5.3 is no longer used in production and PR is not compatible with it.
As part of removing support for PHP 5.3, remove homebrew http response function as 5.4 features a built in one.
This reverts the patch ont the write API functional tests to support php 5.3
Merged
gregcorbett
approved these changes
Jul 15, 2021
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ~#190 ~