Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-95 Reduce xml schema file loading for validating data entry values #301

Merged
merged 2 commits into from Mar 8, 2023
Merged

GT-95 Reduce xml schema file loading for validating data entry values #301

merged 2 commits into from Mar 8, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2021

Fixes #254

Including commit with cosmetic changes to calm PHP Mess detector warnings.

@ghost ghost self-requested a review as a code owner August 23, 2021 15:18
@gregcorbett gregcorbett added this to the 5.12.0 milestone Feb 15, 2022
@gregcorbett gregcorbett modified the milestones: November 2022, June 2023 Nov 2, 2022
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this to resolve the conflicts?

@tofu-rocketry tofu-rocketry changed the title Reduce xml schema file loading for validating data entry values GT-95 Reduce xml schema file loading for validating data entry values Mar 7, 2023
@ghost
Copy link
Author

ghost commented Mar 7, 2023

Rebased to current dev and removed commit containing code standards updates to Site.php as it didn't contribute to the functionality of this pull request.

@gregcorbett gregcorbett self-assigned this Mar 8, 2023
@gregcorbett gregcorbett merged commit dbc5b0e into GOCDB:dev Mar 8, 2023
@ghost ghost deleted the schema-loading branch March 8, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load schema xml file only once per request.
1 participant