Allow single quote in user identifiers to dev #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This reverts commit d181cf6, reversing changes made to 5d6dea3. - PR #146 was erroneously merged into master. - I don't want this feature (Allow multi email input for Service Group EMAIL) in 5.7.6 as it is not part of that release branch so has not been tested in preproduction. - PR #247 ensures the feature is in the dev branch. The feature is already part of the release-5.8.0 branch.
Release 5.7.6 to master
Release 5.8.0 to master
Release 5.8.1 to master
Release 5.9.0 to master
Release 5.10.0 to master
- GOCDB has historically allowed single quote characters in DNs,
so this is needed for useridentifiers (which can be a DN).
- i.e. A user cannot migrate to using user identifiers if their
current cert DN is considered an invalid user identifiers
gregcorbett
changed the title
gregcorbett
force-pushed
the
hotfix-5.10.X
branch
from
81e46e9 to
83f38c4
Compare
ghost
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject to #396 being reviewed, this PR contains no unreviewed code.