Add an access_test method to API to dev #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow single quote in user identifiers to master
- so Service Owners can verify their hosts will retain access to the API after access to personal data is restricted. - Requires a change to authByIdentifier and isRestrictPDByRole to force the restrictions for the test method regardless of the wider API access rules - I haven't included Users in this API check as I don't want to encourage human users talking to the API.
|
If xml is returned, shouldn't it be roughly complete? Something like maybe, consistent with the other method returns? Lazy parsing of the result could still just grep for |
|
Sounds good, please do suggest the code you put together that generated that XML |
- as I have touched it in this PR and a PR in dev updates the code style of the wider file.
ghost
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject to #401 being reviewed, this PR contains no unreviewed code.