Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code standards for multiple API auth credentials with same identifier #421

Merged
merged 1 commit into from Feb 3, 2023
Merged

Code standards for multiple API auth credentials with same identifier #421

merged 1 commit into from Feb 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2023

Code standards to changes handling multiple API auth credentials with same identifier.

Formatting and other changes where practical and limited to files committed.

Apply code standards
3b78839 
Formatting and other changes where practical and limited
to files committed.
@ghost ghost self-requested a review as a code owner February 2, 2023 11:07
gregcorbett
gregcorbett approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregcorbett
Copy link
Member

I've captured (some) of the codeclimate issues that remain in #422 and #423

@gregcorbett gregcorbett self-assigned this Feb 3, 2023
@gregcorbett gregcorbett added this to the June 2023 milestone Feb 3, 2023
@gregcorbett gregcorbett merged commit 888f059 into GOCDB:dev Feb 3, 2023
@ghost ghost deleted the multiple-apiauth-standards branch February 6, 2023 09:52
@gregcorbett
Copy link
Member

I've captured (some) of the codeclimate issues that remain in #422 and #423

and now #427 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregcorbett gregcorbett

Labels
enhancement
Projects
None yet
Milestone
5.11.0
Development

Successfully merging this pull request may close these issues.
1 participant
@gregcorbett