Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link for viewing services within scope. #424

Merged

Conversation

Letizia97
Copy link
Contributor

Resolves #349 .

@Letizia97 Letizia97 requested a review from a team as a code owner February 6, 2023 12:01
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you change the commit author? At the moment it's root@host-....nubes.stfc.ac.uk.

You should be able to do that via: https://www.git-tower.com/learn/git/faq/change-author-name-email, specifically:

  • Changing Your Committer Name & Email Globally / Changing Your Committer Name & Email per Repository
  • Using --amend for the Very Last Commit

@Letizia97 Letizia97 force-pushed the Issue_349_Incorrect_link_for_services branch 2 times, most recently from 39c5664 to 67937f0 Compare February 6, 2023 14:03
@Letizia97
Copy link
Contributor Author

Just changed committer email and name!

@gregcorbett
Copy link
Member

Rebasing

@gregcorbett gregcorbett force-pushed the Issue_349_Incorrect_link_for_services branch from 67937f0 to f08d91a Compare February 6, 2023 15:20
@gregcorbett gregcorbett merged commit c053352 into GOCDB:dev Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link shown for Services on Page_Type=Scope is incorrect
2 participants