Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the beta channel phpcodesniffer #443

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

gregcorbett
Copy link
Member

@gregcorbett gregcorbett added this to the May 2023 milestone Mar 22, 2023
@gregcorbett gregcorbett requested a review from a team as a code owner March 22, 2023 09:01
@gregcorbett gregcorbett self-assigned this Mar 22, 2023
@rowan04
Copy link
Member

rowan04 commented Mar 22, 2023

14841 issues to fix?!

@gregcorbett
Copy link
Member Author

14841 issues to fix?!

Haha yep, I hoping that means codeclimate is now picking up PSR12 style issues, and it's treating them as new issues because these issues aren't currently detected on dev. But I can't confirm that because there are too many issues for codeclimate to render (which is why I had some test PRs: #441 and #442).

Another hope is that PRs checked after this one has been merged will be compared to this new 14841 baseline - and as such the change will be useful.

If merging this PR means that all future PRs codeclimate just says "too many issues", then this change is not useful and I shall revert.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with proviso I'm not sure exactly what the rules governing beta channel release are.

@gregcorbett gregcorbett merged commit 5e57abb into GOCDB:dev Mar 22, 2023
@gregcorbett gregcorbett deleted the beta_codeclimate branch March 22, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants