Soft drop PHP 5.X support, in favour of PHP 7.4 "out of the box" #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit drops support for PHP 5.X, in favour of PHP 7.4
support "out of the box".
- It is still possible to run GOCDB on PHP 5.X - however this
will require specific deployments reverting this commit
to restore the appropriate composer files.
- The `composer-5.4.{json, lock}` files will remain in the
short term to facilitiate continued testing of the
codebase against PHP 5.X. These files will be removed
from the repository after 1st July 2024.
- NB: The diff rendered here is slightly weird.
- it appears as a rename of the composer-7.4 files to the
composer-5.4 files, which is not what has happened.
- the pre-existing composer files were renamed to
composer-5.4 files and then the composer-7.4 files
were renamed to the composer files
Merged
|
#494 is the PR to actually drop PHP 5.X support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR soft drops support for PHP 5.X, in favour of PHP 7.4 support "out of the box".
It is still possible to run GOCDB on PHP 5.X - however this will require specific deployments reverting this commit to restore the appropriate composer files.
The
composer-5.4.{json, lock}files will remain in the short term to facilitiate the above and to enable continued testing of the codebase against PHP 5.X. These files will be removed from the repository after 1st July 2024, along with automated testing of PHP 5.X.NB: The diff rendered here is slightly weird...