Addition of boolean to services and sites for notifications #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofu-rocketry
approved these changes
Oct 27, 2017
Additional boolean (default false) to site and service 'notify'. Note this changes the schema, upgrades will require additional steps (see https://github.com/GOCDB/gocdb/blob/master/INSTALL.md#updateddl).
Adds ability to update the notify property of sites and services to their respective services.
Changes to the web frontend to enable the setting of a boolean for whether notifications are wanted for a given site or service.
Addition of notifications boolean to output for get_site and get_service PI outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema changes: Note this pull request contains schema changes which will require the additional steps to enable
Changes to entities, services, and web front end to add a boolean to Sites and Services for notifications.