WIP: feat: composite action that wraps fog.buildtools #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urwrstkn8mare
requested changes
Apr 29, 2023
| output='${{ inputs.build }}', | ||
| third_party_output='${{ inputs.third-party-target }}', | ||
| requirements='${{ inputs.requirements }}', | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ) | |
| ) | |
| - name: Zip build | |
| uses: thedoctor0/zip-release@0.7.1 | |
| with: | |
| type: 'zip' | |
| filename: 'build.zip' | |
| path: 'build' |
might as well zip it here
There was a problem hiding this comment.
hm, might be... firstly I wanted take out any top level decisions (like zip naming) from that action, so it has to be done on plugin side, but plugin name and uuid could be both passed on this action too... idk
UncleGoogle
force-pushed
the
feat/simple_composite_action
branch
from
4fd5f19 to
9e138cf
Compare
Co-authored-by: urwrstkn8mare <42769125+urwrstkn8mare@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used in all our forks (both for releasing process and CI -- with functional tests in the future in mind)
WIP - probably does not work. Any comments welcomed.
I won't have more time this week, but started do have something. Feel free to contribute.