Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/current version #2

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix/current version #2

merged 1 commit into from
Jun 27, 2023

Conversation

urwrstkn8mare
Copy link
Member

@urwrstkn8mare urwrstkn8mare commented Jun 27, 2023

it doesn't really matter that the zips aren't in the releases yet imo

we should probably think about the security implications of being able to edit the release after the fact. the only real solution is to find a file hosting provider provides a url that depends on the contents of the file (url changes if file changes). we could do this by just hosting the files in a repo. but tbh if the members of the repo are trusted it should be alr

@UncleGoogle
Copy link

UncleGoogle commented Jun 27, 2023

IMO lets focus now on:

  • finishing release action (yea, that on me, but if you have time to help, please create dummy repo with plugin-like structure and currenct_version.json file to test it live)
  • add sync action to .github here (not blocked, we can streamline updates to this repo this way)

@ABaumher
Copy link
Collaborator

Let me get the release up there so it actually works, lol.

@ABaumher
Copy link
Collaborator

some files are part of the repo from the rebase that should not be. They aren't breaking, but if we are doing fixes, may as well do all of it.

@ABaumher
Copy link
Collaborator

The orig file in protobuf_files just sort of magically appeared and can be removed. It does not affect anything. But it's not blocking so you can merge this in.

@ABaumher
Copy link
Collaborator

ABaumher commented Jun 27, 2023

nvm, i just made it a branch on my repo and dealt with it there. See #3

Edit: All of this started because i was going to make the zips for the Nebula release based on the rebase code and wanted to make sure i didn't break anything. (I didn't) Holy Toledo, Batman!

@urwrstkn8mare urwrstkn8mare merged commit 5d36de4 into master Jun 27, 2023
@urwrstkn8mare urwrstkn8mare deleted the fix/current_version branch June 27, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants