hopefully the real fix for garmin_xt tool issues. #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix LGTM detected "Comparison between i of type uint8_t and Count of wider type int." This latest find by LGTM is one in a long series of issue detections by various tools. However, close analysis reveals the previous solutions to these deteced issues didn't find or fix the real root issues: commit 233f3c8, 10/22/2013, Pad internal buffer to appease -fsanitize=address. While the fix appeased the sanitizer, it didn't fix the root problem. The root problem was a bug in the original translation of format_garmin_xt_decrypt_trk_blk when converting to zero-based array indexing. commit dcf0dd8, 7/8/2015, A bunch of busy work to satisfy hyperactive warnings in newer GCC builds. Again, the fix didn't fix the root problem. The root problem was a bug in the original translation of format_garmin_xt_proc_strk. This bug resulted in a mismatch between our test output and that of the original project. In our output the timestamp of the last two points in a track was identical. This fix results in our output matching the reference file of the original project (with allowances for precision).
|
This pull request fixes 1 alert when merging 9eac482 into 727df52 - view on LGTM.com fixed alerts:
|
|
I note that with this fix the first track in the saved track reference file garmin_xt_strk.gpx matches the active track reference file garmin_xt_atrk.gpx, except for the latitude of the first point. This single mismatch is also present in the original project. Previously the times did not match for all but the last point. The atrk and strk read code is separate. The near alignment of the active and saved tracks supports the changes in this PR. The disagreement about the latitude of the first point is unexplained, and not effected by this PR. |
|
The mismatch in the first latitude between the active and saved tracks appears to be because the latitude is stored at higher resolution in the active track file compared to the saved track file. |
robertlipe
added a commit
that referenced
this pull request
Dec 8, 2021
commit 40429dd Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Mon Dec 6 16:37:53 2021 -0700 fix dotnet time conversion (#784) commit 54b0136 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Mon Dec 6 07:13:44 2021 -0700 Kill CarteSurTable format. (#783) Apparently it hasn't ever been used. Our sample has coordinates in UTM, but we have been interpretting them as degrees/100000. "Le pic du midi" referred to in the sample is The Pic du Midi de Bigorre. commit 1ed5895 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Dec 5 15:30:05 2021 -0700 harden gbfgetcstr, gbfgetpstr. (#782) Hangs were detected with afl and the gdb reader and gbfgetcstr. One such hang reads a fuzzed 32 bit url count with FREAD_i32, and then proceeds to fetch that many strings with FREAD_CSTR_AS_QSTR. This results in fetches from beyond EOF that are undetected. gbfgetcstr_old is modified to throw a fatal error if reading is attempted beyond EOF. A similar failure was not detected with gbfgetpstr, but it is also modified to throw a fatal error if reading is attempted beyond EOF. commit 85502cb Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Dec 3 07:16:02 2021 -0700 hopefully the real fix for garmin_xt tool issues. (#781) Fix LGTM detected "Comparison between i of type uint8_t and Count of wider type int." This latest find by LGTM is one in a long series of issue detections by various tools. However, close analysis reveals the previous solutions to these deteced issues didn't find or fix the real root issues: commit 233f3c8, 10/22/2013, Pad internal buffer to appease -fsanitize=address. While the fix appeased the sanitizer, it didn't fix the root problem. The root problem was a bug in the original translation of format_garmin_xt_decrypt_trk_blk when converting to zero-based array indexing. commit dcf0dd8, 7/8/2015, A bunch of busy work to satisfy hyperactive warnings in newer GCC builds. Again, the fix didn't fix the root problem. The root problem was a bug in the original translation of format_garmin_xt_proc_strk. This bug resulted in a mismatch between our test output and that of the original project. In our output the timestamp of the last two points in a track was identical. This fix results in our output matching the reference file of the original project (with allowances for precision). commit 727df52 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Dec 1 17:17:40 2021 -0700 retire cet (#777) * teach mkshort to split utf8 on grapheme boundaries. and retire some cet functions. * add the grapheme test. * wean gbfile from cet. * restore cet.cc, cet.h in prepare for deprecation. * retire cet.cc, cet.h * drop attempted support of \r line endings in gbfgetutf16str. * add test of surrogate pairs for gbfgetutf16str. * fix test commit 2371d11 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Dec 1 13:11:33 2021 -0700 add lgtm configuration file (#780) commit 1682055 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Dec 1 12:40:38 2021 -0700 move Qt6 CI builds to 6.2.2. (#779) commit d377ef6 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Dec 1 06:26:08 2021 -0700 convert arcdist, polygon, and xcsv to use gpsbabel::TextStream instead of gbfgetstr (#778) * read style files with a textstream. * use gpsbabel::textstream instead of gbfile. commit f2da18d Merge: 41cdf06 2341445 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Tue Nov 30 15:46:26 2021 -0700 Merge pull request #776 from tsteven4/nits3 miscellaneous minor fixes III commit 41cdf06 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Mon Nov 29 07:29:41 2021 -0700 move Qt 5.12 CI builds to 5.12.12 (#774) commit 2341445 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Nov 28 07:44:28 2021 -0700 remove support for non standard entity replacements. This was disabled in d47e364 August 29, 2005. commit dd56f42 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sat Nov 27 23:37:59 2021 -0700 fix lgtm detected ill-defined for loop. commit 59a325d Merge: 56c86e2 0769479 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sat Nov 27 17:45:30 2021 -0700 Merge pull request #772 from tsteven4/lgtm miscellaneous minor fixes commit 0769479 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 26 14:42:42 2021 -0700 sequester temporary style files in TMPDIR commit 3f38cef Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Thu Nov 25 10:09:04 2021 -0700 prefer rte_waypt_ct() over waypoint_list.count(). this provides some insulation from the underlying WaypointList container. commit bdd7865 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Thu Nov 25 08:37:57 2021 -0800 sort SOURCES and HEADERS in build. this gives a reasonable initial project view in Xcode. this gives a resaonable order to compilation. commit dd735b6 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 24 11:11:15 2021 -0800 minor correction to resample doc. commit f7d3d60 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 24 10:30:58 2021 -0800 further minimize xcsv_get_char_from_constant_table commit f483fc3 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 24 09:51:14 2021 -0800 use list initialization to construct xcsv char map table. commit d62f479 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 24 08:52:22 2021 -0800 more nits. commit b2957b5 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Tue Nov 23 16:09:14 2021 -0800 limit variable scope, found by LGTM. Poor global variable name 'ops'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). commit 56c86e2 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Tue Nov 23 09:40:30 2021 -0700 fix parsing of nmea hms fields. (#770) commit fa20976 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Nov 21 14:04:55 2021 -0700 Introduce resampling filter and nvectors. (#763) * Introduce resampling filter and nvectors. * use ellipsoid model with nvectors. the code had been forcing a spherical earth model to match the existing grtcirc.cc calculations. commit 1a422a6 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Nov 21 14:04:03 2021 -0700 improve string handling, fix 9 year old FIXME. (#769) commit e09f7fe Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Nov 21 13:34:23 2021 -0700 support generation of xcode project files with qmake. (#760) commit ff76e25 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sat Nov 20 08:05:01 2021 -0700 update fit locations test with improved sample (#767) * update fit test with improved sample. * reference file mode correction. commit 67ad13d Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 19 06:48:53 2021 -0700 Pick up fit locations test case (#766) * Add support for Locations.fit files * patch by tsteven4 to address review comments * Add a test case for Locations.fit files from Garmin devices Co-authored-by: Fabrizio Gennari <fabrizio.ge@tiscali.it> commit 368ad39 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Thu Nov 18 16:40:49 2021 -0700 add test for fit Locations(Lctns) files. (#765) * add test for fit Locations(Lctns) files. * fix new bug with change in Qt6 behavior for fit. commit 871efe3 Author: fabzzap <fabrizio.ge@tiscali.it> Date: Thu Nov 18 22:07:59 2021 +0100 Add support for Locations.fit files (#762) * Add support for Locations.fit files * patch by tsteven4 to address review comments commit 2504d97 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 17 08:52:08 2021 -0700 Eliminiate redundant route_head data member (#764) eliminate redundant route_head data member rte_waypt_ct, replacing it with a member function rte_waypt_ct() that gets the count from the waypoint_list container. commit 0beebdd Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Mon Nov 8 05:22:30 2021 -0700 kill xmap, xmap2006. (#758) * kill xmap, xmap2006. * dprecate obsolete readme. commit 6593293 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 5 15:13:05 2021 -0600 kill xmapwpt. (#757) note is was wounded previously, see #754. commit 7b6235c Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 5 13:01:00 2021 -0600 add fedora 35 to CI. (#756) commit c3bc9c8 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 5 11:17:45 2021 -0600 serial port names (#755) * try qserialportinfo again. * update docker images with qt serial port. * enhance windows device text to match device manager on windows.
GPSBabelDeveloper
added a commit
that referenced
this pull request
Dec 9, 2021
…aggeo, mapsend, nm4, pcx, pocketfms, skyforce, stmsdf, stmwpp, tiger, vpl, vidaone, vitosmt, vitovtt, wfff, and yahoo. (#785) * Remove compegps, cst, g7to2in, gopal, gpsutil, jtr, maggeo, mapsend, nm4, pcx, pocketfms, skyforce, stmsdf, stmwpp, tiger, vpl, wfff, and yahoo. * Missing reference files from above. * Change classic-3 test to read gzipped NMEA instead of deprecated formats. * Drop gpsutil from tomtom test as it tested nothing unique. * Remove gpsman test. It's a unicsv test and this tests nothing of value. * Eliminate use of gpsutil in gpx test; it covered no unique paths. * Update other GPSBabel.pro :-( * Update Cmaeklists enough for successful Mac compile * Cleanup internal doc references to newly retired formats. * Scrub (and commit) the remaining doc changes for what we just deleted. * Squashed commit of the following: commit 40429dd Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Mon Dec 6 16:37:53 2021 -0700 fix dotnet time conversion (#784) commit 54b0136 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Mon Dec 6 07:13:44 2021 -0700 Kill CarteSurTable format. (#783) Apparently it hasn't ever been used. Our sample has coordinates in UTM, but we have been interpretting them as degrees/100000. "Le pic du midi" referred to in the sample is The Pic du Midi de Bigorre. commit 1ed5895 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Dec 5 15:30:05 2021 -0700 harden gbfgetcstr, gbfgetpstr. (#782) Hangs were detected with afl and the gdb reader and gbfgetcstr. One such hang reads a fuzzed 32 bit url count with FREAD_i32, and then proceeds to fetch that many strings with FREAD_CSTR_AS_QSTR. This results in fetches from beyond EOF that are undetected. gbfgetcstr_old is modified to throw a fatal error if reading is attempted beyond EOF. A similar failure was not detected with gbfgetpstr, but it is also modified to throw a fatal error if reading is attempted beyond EOF. commit 85502cb Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Dec 3 07:16:02 2021 -0700 hopefully the real fix for garmin_xt tool issues. (#781) Fix LGTM detected "Comparison between i of type uint8_t and Count of wider type int." This latest find by LGTM is one in a long series of issue detections by various tools. However, close analysis reveals the previous solutions to these deteced issues didn't find or fix the real root issues: commit 233f3c8, 10/22/2013, Pad internal buffer to appease -fsanitize=address. While the fix appeased the sanitizer, it didn't fix the root problem. The root problem was a bug in the original translation of format_garmin_xt_decrypt_trk_blk when converting to zero-based array indexing. commit dcf0dd8, 7/8/2015, A bunch of busy work to satisfy hyperactive warnings in newer GCC builds. Again, the fix didn't fix the root problem. The root problem was a bug in the original translation of format_garmin_xt_proc_strk. This bug resulted in a mismatch between our test output and that of the original project. In our output the timestamp of the last two points in a track was identical. This fix results in our output matching the reference file of the original project (with allowances for precision). commit 727df52 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Dec 1 17:17:40 2021 -0700 retire cet (#777) * teach mkshort to split utf8 on grapheme boundaries. and retire some cet functions. * add the grapheme test. * wean gbfile from cet. * restore cet.cc, cet.h in prepare for deprecation. * retire cet.cc, cet.h * drop attempted support of \r line endings in gbfgetutf16str. * add test of surrogate pairs for gbfgetutf16str. * fix test commit 2371d11 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Dec 1 13:11:33 2021 -0700 add lgtm configuration file (#780) commit 1682055 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Dec 1 12:40:38 2021 -0700 move Qt6 CI builds to 6.2.2. (#779) commit d377ef6 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Dec 1 06:26:08 2021 -0700 convert arcdist, polygon, and xcsv to use gpsbabel::TextStream instead of gbfgetstr (#778) * read style files with a textstream. * use gpsbabel::textstream instead of gbfile. commit f2da18d Merge: 41cdf06 2341445 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Tue Nov 30 15:46:26 2021 -0700 Merge pull request #776 from tsteven4/nits3 miscellaneous minor fixes III commit 41cdf06 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Mon Nov 29 07:29:41 2021 -0700 move Qt 5.12 CI builds to 5.12.12 (#774) commit 2341445 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Nov 28 07:44:28 2021 -0700 remove support for non standard entity replacements. This was disabled in d47e364 August 29, 2005. commit dd56f42 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sat Nov 27 23:37:59 2021 -0700 fix lgtm detected ill-defined for loop. commit 59a325d Merge: 56c86e2 0769479 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sat Nov 27 17:45:30 2021 -0700 Merge pull request #772 from tsteven4/lgtm miscellaneous minor fixes commit 0769479 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 26 14:42:42 2021 -0700 sequester temporary style files in TMPDIR commit 3f38cef Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Thu Nov 25 10:09:04 2021 -0700 prefer rte_waypt_ct() over waypoint_list.count(). this provides some insulation from the underlying WaypointList container. commit bdd7865 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Thu Nov 25 08:37:57 2021 -0800 sort SOURCES and HEADERS in build. this gives a reasonable initial project view in Xcode. this gives a resaonable order to compilation. commit dd735b6 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 24 11:11:15 2021 -0800 minor correction to resample doc. commit f7d3d60 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 24 10:30:58 2021 -0800 further minimize xcsv_get_char_from_constant_table commit f483fc3 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 24 09:51:14 2021 -0800 use list initialization to construct xcsv char map table. commit d62f479 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 24 08:52:22 2021 -0800 more nits. commit b2957b5 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Tue Nov 23 16:09:14 2021 -0800 limit variable scope, found by LGTM. Poor global variable name 'ops'. Prefer longer, descriptive names for globals (eg. kMyGlobalConstant, not foo). commit 56c86e2 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Tue Nov 23 09:40:30 2021 -0700 fix parsing of nmea hms fields. (#770) commit fa20976 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Nov 21 14:04:55 2021 -0700 Introduce resampling filter and nvectors. (#763) * Introduce resampling filter and nvectors. * use ellipsoid model with nvectors. the code had been forcing a spherical earth model to match the existing grtcirc.cc calculations. commit 1a422a6 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Nov 21 14:04:03 2021 -0700 improve string handling, fix 9 year old FIXME. (#769) commit e09f7fe Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sun Nov 21 13:34:23 2021 -0700 support generation of xcode project files with qmake. (#760) commit ff76e25 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Sat Nov 20 08:05:01 2021 -0700 update fit locations test with improved sample (#767) * update fit test with improved sample. * reference file mode correction. commit 67ad13d Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 19 06:48:53 2021 -0700 Pick up fit locations test case (#766) * Add support for Locations.fit files * patch by tsteven4 to address review comments * Add a test case for Locations.fit files from Garmin devices Co-authored-by: Fabrizio Gennari <fabrizio.ge@tiscali.it> commit 368ad39 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Thu Nov 18 16:40:49 2021 -0700 add test for fit Locations(Lctns) files. (#765) * add test for fit Locations(Lctns) files. * fix new bug with change in Qt6 behavior for fit. commit 871efe3 Author: fabzzap <fabrizio.ge@tiscali.it> Date: Thu Nov 18 22:07:59 2021 +0100 Add support for Locations.fit files (#762) * Add support for Locations.fit files * patch by tsteven4 to address review comments commit 2504d97 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Wed Nov 17 08:52:08 2021 -0700 Eliminiate redundant route_head data member (#764) eliminate redundant route_head data member rte_waypt_ct, replacing it with a member function rte_waypt_ct() that gets the count from the waypoint_list container. commit 0beebdd Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Mon Nov 8 05:22:30 2021 -0700 kill xmap, xmap2006. (#758) * kill xmap, xmap2006. * dprecate obsolete readme. commit 6593293 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 5 15:13:05 2021 -0600 kill xmapwpt. (#757) note is was wounded previously, see #754. commit 7b6235c Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 5 13:01:00 2021 -0600 add fedora 35 to CI. (#756) commit c3bc9c8 Author: tsteven4 <13596209+tsteven4@users.noreply.github.com> Date: Fri Nov 5 11:17:45 2021 -0600 serial port names (#755) * try qserialportinfo again. * update docker images with qt serial port. * enhance windows device text to match device manager on windows. * gbfile test can't depend on PCX any longer.\n Might be a hole in coverage. * Remove vitosmt and vitovtt. * Remove jogmap vidaone yahoo * Remove gpsman. * Remove more crumbs of g7towin. * Run automated cleanup on the list of files in commit message to clean up last pieces. * keep gpsutil.h in GPSBabel.pro Co-authored-by: Robert Lipe <robertlipe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix LGTM detected "Comparison between i of type uint8_t and Count of
wider type int."
This latest find by LGTM is one in a long series of issue detections by
various tools. However, close analysis reveals the previous solutions
to these deteced issues didn't find or fix the real root issues:
commit 233f3c8, 10/22/2013, Pad
internal buffer to appease -fsanitize=address. While the fix appeased
the sanitizer, it didn't fix the root problem. The root problem was
a bug in the original translation of format_garmin_xt_decrypt_trk_blk
when converting to zero-based array indexing.
commit dcf0dd8, 7/8/2015, A bunch of
busy work to satisfy hyperactive warnings in newer GCC builds. Again,
the fix didn't fix the root problem. The root problem was a bug in the
original translation of format_garmin_xt_proc_strk. This bug resulted
in a mismatch between our test output and that of the original project.
In our output the timestamp of the last two points in a track was
identical.
This fix results in our output matching the reference file of the original
project (with allowances for precision).