forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make conditional discard flags available externally #3
Closed
Closed
Changes from all commits
Commits
Show all changes
235 commits
Select commit
Hold shift + click to select a range
e5c01b9
Buffer memory op merging pass for s_buffer_load
dstutt ef9b539
[AMDGPU] intrintrics for byte/short load/store
fa5c650
[AMDGPU] Fix issue for zext of f16 to i32
dstutt 72ee292
[AMDGPU] Use waterfall for readlane with non-uniform index
dstutt 7438b5d
[AMDGPU] Fix-up cases where writelane has 2 SGPR operands
dstutt feaf835
[AMDGPU] Implement set of waterfall intrinsics
dstutt 565436a
[RegisterCoalescer] Extend subranges to uses after join
trenouf 3fa50ba
[RegisterCoalescer] Do not eliminateUndefCopy for a partial copy
trenouf c7bf31b
[LiveRangeCalc] Fixed findReachingDefs bug
trenouf 8b6ea62
[RegisterCoalescer] Avoid "Use not jointly dominated by defs" in remo…
trenouf 68e4f33
[RegisterCoalescer] Only look at main ranges in valuesIdentical/follo…
trenouf 30fbc81
Do not force skip over export instruction in PS
perlfu 2635ffd
[AMDGPU] Temporarily disabled immarg check in verifier
trenouf 6587f10
[InstCombine] Fix a vector-of-pointers instcombine undef bug.
trenouf 219314a
[StackProtector][AMDGPU] Uniform values being used outside loop marke…
9bfc4a1
[AMDGPU] Revised optional bounds checking for scratch accesses
perlfu 946e612
[LiveInterval] Removed bogus empty subrange assert
trenouf 27dc5a8
Revert "AMDGPU: Be explicit about whether the high-word in SI_PC_ADD_…
trenouf cd87f1a
[AMDGPU] Add Wave32 Support to Scratch Bounds Checking Pass
perlfu 6efb5e0
[AMDGCN] Support wave32/64 in waterfall intrinsics
dstutt dcf74f4
[AMDGPU] Fix getDwordOffset in buffer mem merging pass
piotrAMD dc3170a
Merge MIMG instructions
piotrAMD b8c9a08
[AMDGPU] Prevent backend override of WGP when using PAL
dstutt ce17a44
Fixed "Merge MIMG instructions"
piotrAMD 1acef8b
[AMDGPU] Temporarily Disable Atomic Optimizer for GFX10
perlfu 2edcce6
[SDA] Don't stop divergence propagation at the IPD.
simoll d050e52
[AMDGPU] gfx10 atomic optimizer changes.
jayfoad d702c00
Reinstate "AMDGPU: Be explicit about whether the high-word in SI_PC_A…
trenouf 5af7874
Partially revert D61491 "AMDGPU: Be explicit about whether the high-w…
trenouf c62b84d
gfx10 atomic opt test fixup
trenouf 4c5cbb2
[AMDGPU] Fix to 'Fold readlane from copy of SGPR or imm'
trenouf c84ccc6
Revert "[AMDGPU] Enable merging m0 initializations."
trenouf f4f9552
[InstCombine][AMDGPU] Simplify tbuffer loads
piotrAMD 37ba27f
[TLI][AMDGPU] AMDPAL does not have library functions
trenouf fc7af57
[AMDGPU] Remove unnecessary movs for v_fmac operands
d0e9bdb
Revert "Reapply "AMDGPU: Split block for si_end_cf""
arsenm 0539a12
Revert "[AMDGPU] Remove unnecessary movs for v_fmac operands"
trenouf 77ceb89
Revert "[InstCombine][AMDGPU] Simplify tbuffer loads"
trenouf ccf09e1
Overwritten with: 77ceb89db41 Revert "[InstCombine][AMDGPU] Simplify …
26f5a10
Buffer memory op merging pass for s_buffer_load
dstutt 76e0a66
[AMDGPU] intrinsics for byte/short load/store
dfe14ed
[AMDGPU] Fix issue for zext of f16 to i32
dstutt 34c9330
[AMDGPU] Fix-up cases where writelane has 2 SGPR operands
dstutt a8dcacf
[AMDGPU] Implement set of waterfall intrinsics
dstutt 5cd6143
[RegisterCoalescer] Extend subranges to uses after join
trenouf ba17323
[RegisterCoalescer] Do not eliminateUndefCopy for a partial copy
trenouf d067cbd
[LiveRangeCalc] Fixed findReachingDefs bug
trenouf 2bb2965
[RegisterCoalescer] Avoid "Use not jointly dominated by defs" in remo…
trenouf 06e3144
[RegisterCoalescer] Only look at main ranges in valuesIdentical/follo…
trenouf c883396
Do not force skip over export instruction in PS
perlfu 18cb9b2
[AMDGPU] Temporarily disabled immarg check in verifier
trenouf f20ae31
[StackProtector][AMDGPU] Uniform values being used outside loop marke…
011e0e0
[AMDGPU] Revised optional bounds checking for scratch accesses
perlfu cef330f
Merge MIMG instructions
piotrAMD cc72be2
[SDA] Don't stop divergence propagation at the IPD.
simoll 8e41591
[AMDGPU] Add llvm.amdgcn.wqm.demote intrinsic
perlfu ce9a97b
Overwritten with: 8e415910ec7 [AMDGPU] Add llvm.amdgcn.wqm.demote int…
4055769
[AMDGPU] Add llvm.amdgcn.wqm.helper intrinsic to complement demote
perlfu 0866736
Overwritten with: 4055769b492 [AMDGPU] Add llvm.amdgcn.wqm.helper int…
9d4e892
Overwritten with: 92b4e096fc2 [AMDGPU] Use waterfall for readlane wit…
6256c6e
Overwritten with: 56002f2cdbb [SLC] Allow llvm.pow(x,2.0) -> x*x etc …
2b5181f
Overwritten with: fbb18a0270f Merged from upstream llvm 373192: ac0f4…
40fbaf4
Overwritten with: b8e91803875 Merged from upstream llvm 373423: [X86]…
33e6f13
Overwritten with: b19c164e79d Remove dubious logic in bidirectional l…
068af91
Overwritten with: acb3c7cf906 Fixes after merge due to change to alwa…
56636f1
Overwritten with: b4d32d7bf5b XFAIL dpp_combine.mir after reverting f…
717c9c6
Revert "[AMDGPU] Come back patch for the 'Assign register class for c…
6b257bf
Revert "AMDGPU: Use SGPR_128 instead of SReg_128 for vregs"
2c15e55
Overwritten with: 6b257bf4153 Revert "AMDGPU: Use SGPR_128 instead of…
2c07340
Revert "AMDGPU: Use SGPR_128 instead of SReg_128 for vregs"
0071048
Overwritten with: 2c07340a810 Revert "AMDGPU: Use SGPR_128 instead of…
65129cf
Merge 2c15e55bc4b into HEAD
220194b
Overwritten with: 3bbd3f1235f Revert "AMDGPU: Use SGPR_128 instead of…
b3cb789
Overwritten with: d401164f02a Merged master:0703db39892 into amd-gfx:…
trenouf 9894965
Overwritten with: a62196f745a Manual merge master:b0c1900820c into am…
trenouf cc9adb3
Overwritten with: a3f66b052d7 Merged master:a9bb669e59f into amd-gfx:…
perlfu 728902d
Overwritten with: 5e3bf90389a AMDGPU: Partially revert Make WQM aware…
perlfu 7858771
Overwritten with: cad42751dee Revert "AMDGPU: Change boolean content …
trenouf 1532478
Revert "AMDGPU: Change boolean content type to 0 or 1"
trenouf a62a00e
Overwritten with: 1532478d480 Revert "AMDGPU: Change boolean content …
trenouf 9dad443
Merged amd-gfx-legal-branch2 into amd-gfx-legal-branch
trenouf 198b0c7
Revert "[InstCombine] remove identity shuffle simplification for mask…
jayfoad cc0df5a
Overwritten with: 198b0c7191b Revert "[InstCombine] remove identity s…
trenouf 0549a86
Overwritten with: 9333d68d986 Merged master:170ee645f4d into amd-gfx:…
jayfoad c22b899
Overwritten with: 131b8289ffd Merge master:fce1a6f5848 into amd-gfx:9…
piotrAMD 08268e9
Overwritten with: 724d2153965 Merged master:0f0330a7870 into amd-gfx:…
trenouf 1ecf0a1
Overwritten with: 293ea4504e7 Manually merged master:6d6a4590c5d into…
b8057d9
Overwritten with: 293ea4504e7 Manually merged master:6d6a4590c5d into…
trenouf 861404a
Overwritten with: 7ebe0854be14 Manually merged master:b54aa053d3a int…
trenouf 71e5ca0
Overwritten with: 0cd3f3ea2fb2 [AMDGPU] Don't remove short branches o…
trenouf bf355f2
Overwritten with: f54c614eda17 AMDGPU: During img instruction ret val…
trenouf a163b38
Overwritten with: 0d6eb9a09d3 Revert "[codegen,amdgpu] Enhance MIR DI…
4048811
AMDGPU: Correct const_index_stride for wave 32
dstutt 434a284
Overwritten with: 40488113135e AMDGPU: Correct const_index_stride for…
trenouf 3bc4902
Dummy change to td files to fix build problem
878d4bd
Overwritten with: 3bc4902faa7e Dummy change to td files to fix build …
trenouf 0d25720
Cherry-picked: Revert "Revert "Revert "[codegen,amdgpu] Enhance MIR D…
dstutt e404e4b
Overwritten with: 0d25720311ee Cherry-picked: Revert "Revert "Revert …
trenouf 0aab7f3
Overwritten with: 2ad1b3f0b97c Revert "Revert "Revert "[codegen,amdgp…
trenouf 9ad2301
Overwritten with: 80e004f6b881 [AMDGPU] Add transformation of kills t…
trenouf 815afb5
Overwritten with: 46601da50bc Reinstate getSplat(unsigned NumElts, Co…
trenouf 5c958c7
Overwritten with: 0aab7f3563c Overwritten with: 2ad1b3f0b97c Revert "…
trenouf b2b163f
Overwritten with: da5f3adce76 Merged master:536ba6373f0 into amd-gfx:…
trenouf 1ebc431
Overwritten with: c2636080d53 Merged master:ac1d23ed7de into amd-gfx:…
jayfoad 0e27e33
Overwritten with: 82bcf11f39b Revert "Reinstate getSplat(unsigned Num…
trenouf f675b27
Overwritten with: 5583605b7a5 [AMDGPU] Disable endcf collapse again
jayfoad 84d753b
Overwritten with: c60a9bf89b8 [AMDGPU] Revert scratch wave offset cha…
trenouf c7c3927
[AMDGPU] Disable endcf collapse again
jayfoad 50077fc
Overwritten with: c7c392758ea [AMDGPU] Disable endcf collapse again
trenouf 7b14353
Merged amd-gfx-legal-branch3 info amd-gfx-legal
5ae05ed
Overwritten with: d486507dbf1 Merged master:8812b0cc5cc into amd-gfx:…
trenouf a1299ba
Overwritten with: 240ccfe95f7 Revert "[AMDGPU] Set the CostPerUse val…
trenouf 3b3df72
Revert "[AMDGPU] Set the CostPerUse value for vgpr registers."
piotrAMD 15d123d
Overwritten with: 3b3df728f19 Revert "[AMDGPU] Set the CostPerUse val…
trenouf f02738a
Merge amd-gfx-legal-branch4 into amd-gfx-legal
trenouf 53692d9
Overwritten with: ae0e4779765 Merge "[AMDGPU] Avoid more hard-coded l…
jayfoad 4ae16c2
[MsgPack] MsgPackDocument::readFromBlob now merges
c57487b
Overwritten with: 4ae16c21fe3 [MsgPack] MsgPackDocument::readFromBlob…
trenouf 3a1103f
Overwritten with: 536937b3dc3 [AMDGPU] Fixed incorrect PAL metadata r…
7b9d0cf
Overwritten with: 05ca407e6cd Merged master:c295a65da49 into amd-gfx:…
e90e9d4
Overwritten with: c307fd81e7c Manual merge master:1ddac9563d7f into a…
daedcee
Overwritten with: 357ead6e3d1 Suppress switch with only default warni…
trenouf a7cfa00
Overwritten with: 357ead6e3d1 Suppress switch with only default warni…
trenouf 0c3b9cd
Overwritten with: 242b037f79c AMDGPU more fix-ups to the StackPtrOffs…
trenouf f3e0a98
Revert "[AMDGPU] Make SGPR spills exec mask agnostic"
dstutt 3274df1
Overwritten with: f3e0a9859c8 Revert "[AMDGPU] Make SGPR spills exec …
trenouf 7d6e549
[AMDGPU] Temporary fix to get previous intrinsic cost
dstutt da64bde
Overwritten with: 7d6e549c150 [AMDGPU] Temporary fix to get previous …
trenouf 7ce7cdb
Overwritten with: ad0cb955849 Manual merge master:88f722c269a into am…
trenouf cca1a02
Overwritten with: 9a8a1b7f91b Revert "[InstCombine] canonicalize bitc…
perlfu 71b4c58
Overwritten with: c8f92d00575 Merged master:1b10c618e928 into amd-gfx…
trenouf d361f76
Revert "[InstCombine] canonicalize bitcast after insertelement into u…
perlfu a458b29
Overwritten with: d361f76f78e Revert "[InstCombine] canonicalize bitc…
trenouf b3a0782
Merged -sours proposed next amd-gfx-gpuopen-master
trenouf dc1f5d9
Overwritten with: 28c226b4dca Merged master:0ebdc3be417 into amd-gfx:…
trenouf 8abd948
Overwritten with: 28c226b4dca Merged master:0ebdc3be417 into amd-gfx:…
trenouf cc5e107
Overwritten with: 572b5725a74 Merged master:e40315d2b4e into amd-gfx:…
piotrAMD c2ea9a1
Overwritten with: 862f3dac7a1b Merged master:8119d6c14695 into amd-gf…
trenouf 5ad0302
Revert "AMDGPU: Fix verifier error on spilling partially defined SGPRs"
dstutt ea979e9
Overwritten with: 5ad0302ed892 Revert "AMDGPU: Fix verifier error on …
trenouf ccbc834
Overwritten with: a77b6e995c04 Merged master:1454018dc1d9 into amd-gf…
trenouf 1826337
Overwritten with: b4be3a06d7aa Update llvm.amdgcn.wqm.demote.ll
trenouf c72fe64
Overwritten with: a77b6e995c04 Merged master:1454018dc1d9 into amd-gf…
trenouf 240f3dd
Overwritten with: 4ef4636769e7 [AMDGPU] Set DS alignment requirements…
trenouf ff1e992
Overwritten with: c08be3ddc85a Merged master:cb9528a0420e into amd-gf…
trenouf d3f03b3
Overwritten with: 82555a629c63 Merged master:625761825620 into amd-gf…
trenouf 0510352
Overwritten with: aa7b19191b74 [AMDGPU] Correctly update uses of wate…
trenouf bf98770
Overwritten with: eb04fb8d2acb Temporarily revert commits that caused…
trenouf 1598ada
Overwritten with: 19563a6be683 Merged master:9237e73ae8a3 into amd-gf…
trenouf 145729e
Overwritten with: 2f0ca8502416 [AMDGPU] Use WQM Live Mask to Early Te…
trenouf 1825096
Overwritten with: b19d6f8966ea CfgInterface: rename interface() to ge…
trenouf f7d2903
Overwritten with: 6f46063b43db Update llvm.amdgcn.waterfall.ll
trenouf 5cb4dc4
Overwritten with: 7666303f765e [AMDGPU] Extend waterfall support to b…
trenouf e09ed8b
Overwritten with: 68d3270fef04 Merged master:20a3931f8fad into amd-gf…
trenouf f46f369
Overwritten with: 1c7c56ddc669 Merged master:6e008cb554b3 into amd-gf…
trenouf 5b944bf
Overwritten with: 1c7c56ddc669 Merged master:6e008cb554b3 into amd-gf…
trenouf c9860f1
Overwritten with: 6612326f4f49 Merged master:35d625125465 into amd-gf…
trenouf 84d2d98
[AMDGPU] Fix live mask tracking with conditional kill live lanes
perlfu 88613f6
Overwritten with: 84d2d9812f7c [AMDGPU] Fix live mask tracking with c…
trenouf 6d7376c
Overwritten with: adf059689f90 Change waterfall begin for multi-begin
trenouf 15bf319
Overwritten with: c6553e1ac447 Merged master:bd4662cd3f37 into amd-gf…
trenouf fde3d4e
Overwritten with: c6553e1ac447 Merged master:bd4662cd3f37 into amd-gf…
trenouf 529059d
Overwritten with: e39dc60f94f9 [AMDGPU] Waterfall loop insertion afte…
trenouf ae9a45d
Overwritten with: 8954ca68dadc Merge main:3d381a710220 into amd-gfx
trenouf 0472e03
Overwritten with: 352ac6432b9e Merged main:dbfdb139f754 into amd-gfx:…
trenouf 4ad3460
Overwritten with: a2e82546366c Merged main:ad0a7ad950fe into amd-gfx:…
trenouf 9ef380b
Overwritten with: 273a500bfd31 Update bitcast-vec-canon-inseltpoison.ll
trenouf 294f18d
Overwritten with: ee8e7ff0e8c7 Merged main:5471b1fa4013 into amd-gfx:…
trenouf 1d0178f
Overwritten with: d7af18dfc774 Merged main:f8cece186305 into amd-gfx:…
jayfoad bcd2fe4
Overwritten with: 87fe2f5a21f0 Merged main:b62c7e047420 into amd-gfx:…
jayfoad 870d624
Overwritten with: 1f2a806f89a5 Merged main:c8d2ae52c15b into amd-gfx:…
jayfoad 6937c95
Overwritten with: c16ec8fd3792 Merged main:231a82a150b3 into amd-gfx:…
jayfoad 32030dd
Overwritten with: 6b2a0812b8eb Merged main:f9d7f77267bc into amd-gfx:…
trenouf fb1d44a
Overwritten with: ecf888299b50 Merged main:f2b4cc91e083 into amd-gfx:…
jayfoad 58afc07
Overwritten with: c23e7ed7b622 Merged main:edc8f0b407a1 into amd-gfx:…
jayfoad fef6a69
Overwritten with: ecfe8a65a49a Merged main:7786ac8377a2 into amd-gfx:…
trenouf 28beb06
Overwritten with: 2b3526158966 [AMDGPU] Fix discard optimisation tests
trenouf 581d625
Overwritten with: 6e900ba9cb41 Revert "[NARY-REASSOCIATE] Support rea…
trenouf 22bd490
Overwritten with: 5e4f55625d36 Merged main:76148caa505c into amd-gfx:…
trenouf 570c8bd
Overwritten with: dd09dc7f08a1 Merged main:80d1f657a157 into amd-gfx:…
trenouf 9997000
[AMDGPU] Fix shortfalls in WQM marking
perlfu 9ab78c7
Overwritten with: 999700080911 [AMDGPU] Fix shortfalls in WQM marking
trenouf 42e39a9
Overwritten with: e057c3c40b8f Merged main:c0cd5274ccdb into amd-gfx:…
trenouf 20799ac
Merge amd-gfx-legal-branch6 history into amd-gfx-legal to avoid histo…
trenouf 3e6e76e
Overwritten with: 201c334669ac Merged main:f7ef26ef0b29 into amd-gfx:…
trenouf 42e672d
[AMDGPU] Avoid unnecessary graph visits during WQM marking
perlfu 127ee7a
Overwritten with: 42e672d2ddcb [AMDGPU] Avoid unnecessary graph visit…
trenouf 53cfaa9
Dummy merge branch back in to preserve history
trenouf 06c283b
Overwritten with: 1112542ccd16 [AMDGPU] Fix very minor merge artefacts
trenouf 661ac9b
Overwritten with: 91f6a57d9fd8 Merged main:2a2720a2dec4 into amd-gfx:…
trenouf 59efb26
Overwritten with: 2c1ed7c0c1c3 Merged main:eae0ac3a1f4c into amd-gfx:…
trenouf 839f787
Overwritten with: 3a0c9df069fb Merged main:d2223c7a4997 into amd-gfx:…
trenouf c337d1a
Overwritten with: 5738a995acb4 Merged main:d78782f6a6ee into amd-gfx:…
trenouf 2d65a54
Overwritten with: 81e2d58b4b39 Merged main:efc31be7f8e8 into amd-gfx:…
trenouf 6f3cc6a
Overwritten with: af8edf41f32b Test fix from 'revert "[InstCombine] c…
trenouf f4a2a23
Overwritten with: af8edf41f32b Test fix from 'revert "[InstCombine] c…
trenouf 06c125a
Overwritten with: 2599d6415711 Merged main:5781f9a74342 into amd-gfx:…
trenouf 1b94c3b
Overwritten with: 0001d14b8267 Merged main:a4b61c82cf1a into amd-gfx:…
trenouf 7da5ed4
Overwritten with: 17f566ae20f1 Merged main:9d070b2f4889 into amd-gfx:…
trenouf d087c39
Overwritten with: be05523823fc Merged main:6455418d3d2a into amd-gfx:…
trenouf 5f0d44a
Overwritten with: 10a2b322ac71 [LVI] Remove recursion from getValueFo…
trenouf 2ef30b5
Overwritten with: 0c4a7cf1b0d9 Merged main:01cb9c5fc52b into amd-gfx:…
trenouf 0cb96bc
Overwritten with: c4564c99373f Revert DAGCombine changes
trenouf a629c23
Fix 224-bit spills
piotrAMD c654ffe
Overwritten with: a629c23e9858 Fix 224-bit spills
trenouf 0a3fa7f
Overwritten with: c753832388c6 Merged main:c7b658aeb526 into amd-gfx:…
trenouf 01f326c
Overwritten with: 7f371685abc5 Merged main:85bac9d7f934 into amd-gfx:…
trenouf 4f968af
Overwritten with: c2de1b519b17 Merged main:da92e86263c3 into amd-gfx:…
trenouf 53de8fe
Overwritten with: 8458a1269744 Merged main:15bf66d2f831 into amd-gfx:…
trenouf 35321a0
Overwritten with: 25f485bd7483 Merged main:8a241cd9c247 into amd-gfx:…
trenouf 9afbdfd
Overwritten with: a40511dd730b Merged main:2d9759c7902c into amd-gfx:…
trenouf 3490d8b
Overwritten with: 9a2e48d2e754 Merged main:df06ec305753 into amd-gfx:…
trenouf 0ef836c
[SimpifyCFG] Remove recursion from FoldCondBranchOnPHI. NFCI.
perlfu b297d10
Overwritten with: 0ef836c86a71 [SimpifyCFG] Remove recursion from Fol…
trenouf e1fa820
Merge history of 'amd-gfx-legal-branch8' without modifying tree
trenouf 01ca55c
Overwritten with: 7cac7a29d809 Merged main:ccfc07904769 into amd-gfx:…
trenouf 02a00c5
Overwritten with: 0fba726b49f3 Merged main:b546f4347b87 into amd-gfx:…
trenouf fd071e5
Overwritten with: 88a23aab69f5 Merged main:4b1fde8a2b68 into amd-gfx:…
trenouf 68e5420
Overwritten with: b3d94b931a59 Merged main:76529b446859 into amd-gfx:…
trenouf 8207d5d
Overwritten with: 6afa0ba35a78 Merged main:df7c2bcf4e45 into amd-gfx:…
trenouf b9fc2ab
Overwritten with: 86a1be7d8417 Merged main:9eab0da18320 into amd-gfx:…
trenouf 59f5ac3
Revert "[AMDGPU] Propagate defining src reg for AGPR to AGPR Copys"
piotrAMD ff6b29f
Overwritten with: 59f5ac3c8e2e Revert "[AMDGPU] Propagate defining sr…
trenouf 4d25fb2
Overwritten with: 54d481e0534e Merged main:587493b441ea into amd-gfx:…
trenouf 16f6bc2
Overwritten with: 7df23f4e976b Merged main:85bf221f204e into amd-gfx:…
trenouf 73b4a76
Overwritten with: c2eb50153bf7 Merged main:eee887e03551 into amd-gfx:…
trenouf 413996e
Overwritten with: fa046d1222f2 Merged main:091244023ac3 into amd-gfx:…
trenouf ad9f69a
Overwritten with: 14be41077f2e Merged main:d61eb6c5d97b into amd-gfx:…
jayfoad cdd7483
Overwritten with: b281f78e2862 Merged main:97b9e8438e26 into amd-gfx:…
trenouf b059b7d
Overwritten with: 5192b57847f1 Merged main:7a54ae9c1d42 into amd-gfx:…
jayfoad 9f7a599
Overwritten with: 9eb9e496c0cf Merged main:6a7db0dc8eef into amd-gfx:…
jayfoad c6950e0
Overwritten with: fe9e67d290b7 Merged main:a995cdab1908 into amd-gfx:…
trenouf aaa34e1
Overwritten with: 9d4865385485 Merged main:e9262edf0d11 into amd-gfx:…
Guzhu-AMD c20ba76
Overwritten with: 1a7b3468b760 Merged main:4edb9983cb8c into amd-gfx:…
Guzhu-AMD f002213
Make conditional discard flags available externally
kuhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
llvm/test/CodeGen/AMDGPU/coalescing-subreg-removed-undef-copy.mir
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
llvm/test/CodeGen/AMDGPU/llvm.amdgcn.raw.atomic.buffer.load.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
llvm/test/CodeGen/AMDGPU/regcoal-followcopychain-bogus-subrange-comparison.mir
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
llvm/test/CodeGen/AMDGPU/regcoal-followcopychain-different-subreg-diffs.mir
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
llvm/test/CodeGen/AMDGPU/regcoal-removepartial-redundancy-not-jointly-dominated.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
llvm/test/CodeGen/AMDGPU/regcoalescer-assert-from-incorrect-subrange-extension.mir
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular objection, but I haven't seen this pattern before of putting the option itself (
EnableConditionalDiscardTransformations
) in thecl
namespace. Is it used elsewhere in LLVM?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does seem to be used occasionally elsewhere in LLVM.
Exposing this option seems fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this pattern used in LLPC, e.g.,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could put it in namespace llvm instead of llvm::cl. Both work for me.