You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The line of code above weights the number of hemispherical samples by 1/probe_size when computing SH coefficients for later shading, however the number of samples is probe_size*probe_size. The normalization seems incorrect however if i change the weight to 1/(probe_size*probe_size) the scene seems to be too dark compared to the ray-traced reference.
The text was updated successfully, but these errors were encountered:
Maybe an integral area multiplier (4 x PI) is also missing? And by conicidence 4 x PI (12+) and 1/probe_size (1/8) canceled out making the final shading result about 50% darker than the PT reference. Tone mapping further mitigated the difference.
Hineven
added a commit
to Hineven/Capsaicin
that referenced
this issue
Jun 23, 2024
Capsaicin/src/core/src/render_techniques/gi10/gi10.comp
Line 1462 in d642e5d
The line of code above weights the number of hemispherical samples by
1/probe_size
when computing SH coefficients for later shading, however the number of samples isprobe_size*probe_size
. The normalization seems incorrect however if i change the weight to1/(probe_size*probe_size)
the scene seems to be too dark compared to the ray-traced reference.The text was updated successfully, but these errors were encountered: