Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasisCurves improvements #282

Merged

Conversation

hshakula
Copy link
Contributor

New

  • Support for curves of bezier basis
  • Primitive support for catmullRom and spline bases by interpreting them as linear
  • Support varying interpolation for widths
  • Optimized a bit memory usage for linear curves - there is no need to allocate memory for dummy indices when there are no authored ones

Open Questions

  • Should we consider converting (in the plugin) catmullRom and spline bases to bezier or the current behavior is sufficient?

@hshakula
Copy link
Contributor Author

Here's an example of bspline curves that are interpreted as linear for RPR

bspline_as_linear

Render from Karma

bspline_karma

Curves asset is a carpet from Esper Room by Multiverse

@bsavery
Copy link
Contributor

bsavery commented May 20, 2020

How do Catmull Rom curves work now?
IMO RPR itself should do the conversion from segments to curved scheme

@hshakula
Copy link
Contributor Author

How do Catmull Rom curves work now?

Same as bspline - data interpreted as linear

IMO RPR itself should do the conversion from segments to curved scheme

Do you have examples?

@bsavery
Copy link
Contributor

bsavery commented May 20, 2020

Meaning you should load a bunch of points into RPR and tell it how to interpolate the curves, linear, etc https://rmanwiki.pixar.com/display/REN23/Curves

@hshakula
Copy link
Contributor Author

Well, that would be ideal, but for now, RPR curves can only be of bezier type. So even linear curves are not completely correct.

Correct me if I'm wrong

@bsavery
Copy link
Contributor

bsavery commented May 22, 2020

No you're correct. I just am saying we should propose that to RPR SDK.

@bsavery bsavery merged commit 1ae5806 into GPUOpen-LibrariesAndSDKs:master May 22, 2020
@hshakula hshakula deleted the bezier-curves-support branch May 22, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants