Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed tone mapping filter support #283

Merged
merged 1 commit into from
May 20, 2020

Conversation

hshakula
Copy link
Contributor

While working with indoor scenes (like the attic and the esper room) I felt the need to apply tone mapping. So as RIF already has a bunch of tone mapping filter I tested a few of them and selected the most versatile one - Linear Photographic Tone Mapping Filter.

It's possible to add support for more tone mapping filters but I don't feel such need right now

@bsavery
Copy link
Contributor

bsavery commented May 18, 2020

What reason made you decide this vs the ACES filmic one? The latter is often used as well.

@hshakula
Copy link
Contributor Author

When I first saw the list of tone mapping filter, I also thought that I would stick to ACES filter but when I tried it and, especially compared it to Linear Photographic, I understood that it's not an option because of how much better I can control the output image with almost the same set of options. The second reason is more subjective - I just liked the output more with this filter, It coincided more with the output which I expect.

As I can see RIF's ACES filter is just fitted curve from here - https://knarkowicz.wordpress.com/2016/01/06/aces-filmic-tone-mapping-curve/
But, as the author states, this curve is not the best choice for realistic rendering

@bsavery bsavery merged commit 381d4c1 into GPUOpen-LibrariesAndSDKs:master May 20, 2020
@hshakula hshakula deleted the embed-tonemapper branch May 21, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants