Fixes for internally tagged enums and flattening additional_properties #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they might. flatten doesn't act quite as intended with regard to additional_properties
|
@GREsau could I ask you to take a look at this? |
|
Thanks, this is now published in v0.8.8 :) |
ahl
added a commit
to oxidecomputer/typify
that referenced
this pull request
Dec 6, 2021
ahl
added a commit
to oxidecomputer/typify
that referenced
this pull request
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flattening has some surprising outcomes when it comes to the
additional_propertiesfield. Consider thatNoneis equivalent toSome(Schema::Bool(true)); merge currently prefers anySometo anyNoneirrespective of the contents. Given the context of merge/flatten, the result of merging twoadditional_fieldvalues should be the union of the two schemas i.e. the schema that validates either.This is particularly relevant for internally tagged schemas where currently additional properties are allowed even when
deny_unknown_fieldsis set and can be constrained e.g. when a variant such asStringMap(Map<&'static str, &'static str>),is present.