update webrtc deps, update frontend deps, fix misc bugs #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpoopyTim
suggested changes
Apr 18, 2022
| // Read RTP packets forever and send them to the WebRTC Client | ||
| for { | ||
|
|
||
| n, _, err := listener.ReadFrom(inboundRTPPacket) | ||
|
|
||
| once.Do(func() { fmt.Print("houston we have a packet") }) |
There was a problem hiding this comment.
I want to keep this one in since its useful to know when we receive the first RTP packet. I plan on overhauling the logging here next though and will make it nicer :)
| // Read RTP packets forever and send them to the WebRTC Client | ||
| for { | ||
|
|
||
| n, _, err := listener.ReadFrom(inboundRTPPacket) | ||
|
|
||
| once.Do(func() { fmt.Print("houston we have a packet") }) | ||
|
|
||
| if err != nil { | ||
| fmt.Printf("error during read: %s", err) |
There was a problem hiding this comment.
Here too, although this one could be intentional
There was a problem hiding this comment.
yeah this one is intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.