Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for login.gov authentication #124

Merged
merged 11 commits into from
Nov 18, 2024
Merged

Conversation

aanand-gsa
Copy link
Contributor

This issue resolves #113 by adding required configurations relating login.gov for authentication.

@aanand-gsa aanand-gsa marked this pull request as ready for review November 13, 2024 20:00
Copy link
Contributor

@danielnaab danielnaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I had a small suggestion on the branching logic in AuthenticationImplementation, but use your discretion on it.

@aanand-gsa aanand-gsa merged commit bd0c714 into main Nov 18, 2024
1 check passed
@aanand-gsa aanand-gsa deleted the issue-113-aanand-login-gov-auth branch November 18, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching the app to login.gov authentication
2 participants