Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and List Data Providers #17

Merged
merged 25 commits into from
Dec 18, 2023
Merged

Add and List Data Providers #17

merged 25 commits into from
Dec 18, 2023

Conversation

akuny
Copy link
Collaborator

@akuny akuny commented Dec 13, 2023

Allows users to add data providers by way of poetry run add-provider {provider_name} and list all providers by way of poetry run list-providers.

To run locally in development, create an .env file in the root directory and set it up as such:

DATABASE_URL=sqlite:///nad_ch/infrastructure/database.sqlite3

Once that's set up, you can run poetry run init-db to build a local development database.

Tests run via poetry run test.

Copy link
Collaborator

@danielnaab danielnaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had some suggestions, but definitely use your own judgment if they all make sense.

nad_ch/controllers/cli.py Outdated Show resolved Hide resolved
nad_ch/controllers/cli.py Outdated Show resolved Hide resolved
scripts/init_db.py Show resolved Hide resolved
tests/mocks.py Outdated Show resolved Hide resolved
nad_ch/domain/repositories.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@danielnaab danielnaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@akuny akuny merged commit d780551 into main Dec 18, 2023
1 check passed
@akuny akuny deleted the providers branch January 24, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants