Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Submissions #18

Merged
merged 11 commits into from
Dec 28, 2023
Merged

Data Submissions #18

merged 11 commits into from
Dec 28, 2023

Conversation

akuny
Copy link
Collaborator

@akuny akuny commented Dec 19, 2023

  • Add CLI controller actions to ingest a data submission and list data submissions by provider
  • Add use cases used by these two actions
  • Add repository implementation for DataSubmission
  • Update Entity and SqlAlchemy model classes to handle created_at and updated_at date fields

@akuny akuny requested a review from danielnaab December 19, 2023 20:16
Copy link
Collaborator

@danielnaab danielnaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - sorry for the delay. I'm not sure how best to do the error handling, but maybe just manual cleanup for now would be fine. Maybe it'll be more clear if a data modeling solution is possible once a few more stories are implemented.

nad_ch/use_cases.py Outdated Show resolved Hide resolved
nad_ch/use_cases.py Outdated Show resolved Hide resolved
@akuny akuny merged commit 86fd52c into main Dec 28, 2023
1 check passed
@akuny akuny deleted the submissions branch January 24, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants