Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-validation: AWARD_REF/REF_NUM set uniqueness #1791

Closed
4 tasks
Tracked by #1443
jadudm opened this issue Aug 11, 2023 · 0 comments · Fixed by #1815
Closed
4 tasks
Tracked by #1443

Cross-validation: AWARD_REF/REF_NUM set uniqueness #1791

jadudm opened this issue Aug 11, 2023 · 0 comments · Fixed by #1815
Milestone
Launch (Intake)

Comments

@jadudm
Copy link
Contributor

jadudm commented Aug 11, 2023

Validation Description

For a given AWARD in findings, there should be uniqueness across the REFERENCE numbers.

award ... reference
AWARD-0001 ... 2023-001
AWARD-0001 ... 2023-003
AWARD-0001 ... 2023-004
AWARD-0002 ... 2023-003
AWARD-0002 ... 2023-005

So, award 1 has a unique set of references, {1, 3, 4}. Award 2 has a unique set of {3, 5}. It is possible for a reference to appear in multiple sets. However, it is not allowed to have a reference appear multiple times for a single award; eg. award 1 cannot be {1, 3, 3}.

Section(s):

  • This validation touches ALL sections

 

  • Pre-SAC
  • General Information
  • Audit Information
  • Federal Awards
  • Audit Findings
  • Audit findings text
  • CAP Text
  • Additional UEIs
  • Additional Auditors
  • Audit package (PDF)
  • Tribal data consent
  • Auditee certification
  • Auditor certification

Error(s)

  • This generates one error
  • This possibly generates multiple errors

Error text

f"Award {award-ref} repeats reference {ref}. The reference {ref} should only appear once for award {award-ref}."

Error number

AWARDREFS_202308111031

Notes

Tasks
Beta Give feedback
@jadudm jadudm added this to the Launch (Intake) milestone Aug 11, 2023
@jadudm jadudm changed the title Cross-validation: short summary Cross-validation: AWARD/REF set uniqueness Aug 11, 2023
@jadudm jadudm mentioned this issue Aug 11, 2023
Closed
@sambodeme sambodeme changed the title Cross-validation: AWARD/REF set uniqueness Cross-validation: AWARD_REF/REF_NUM set uniqueness Aug 11, 2023
sambodeme added a commit that referenced this issue Aug 14, 2023
@sambodeme
#1791 Added test cases
b1a4765
@sambodeme sambodeme linked a pull request Aug 14, 2023 that will close this issue
1791 cross validation award refref num set uniqueness #1815
Merged
@sambodeme sambodeme mentioned this issue Aug 14, 2023
Merged
sambodeme added a commit that referenced this issue Aug 15, 2023
@sambodeme
#1791 added newly created cross-validation function to the tree
03c1e6e
jadudm pushed a commit that referenced this issue Aug 16, 2023
@sambodeme
1791 cross validation award refref num set uniqueness (#1815)
740dc9d 
* Added logic to handle cross validation for AWARD_REF and REF_NUMBER uniqueness

* #1791 Added test cases

* #1791 added newly created cross-validation function to the tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Launch (Intake)
Development

Successfully merging a pull request may close this issue.

1791 cross validation award refref num set uniqueness GSA-TTS/FAC
1 participant
@jadudm