Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Logic to Record Workbook Validation Schema Version with SAC Records #4376

Closed
sambodeme opened this issue Oct 11, 2024 · 0 comments
Closed

Implement Logic to Record Workbook Validation Schema Version with SAC Records #4376

sambodeme opened this issue Oct 11, 2024 · 0 comments
Assignees
@sambodeme
Labels
eng

Comments

@sambodeme
Copy link
Contributor

Description

We do not currently record the schema version with SAC records, and while this has been intended for a while, it was not prioritized. Recently, we encountered production issues where users failed validation due to using different workbook template versions. After resolving these issues, the team decided that recording the workbook validation schema version with the SAC record is now a must-have. This ticket is to implement the logic for capturing the schema version along with the SAC record.
@sambodeme sambodeme added the eng label Oct 11, 2024
@sambodeme sambodeme self-assigned this Oct 11, 2024
@sambodeme sambodeme added this to FAC Oct 11, 2024
@github-project-automation github-project-automation bot moved this to Triage in FAC Oct 11, 2024
@sambodeme sambodeme moved this from Triage to In Progress in FAC Oct 11, 2024
sambodeme added a commit that referenced this issue Oct 11, 2024
@sambodeme
#4376 Updated logic to capture schema version in SAC record
3de9b72
sambodeme added a commit that referenced this issue Oct 11, 2024
@sambodeme
#4376 Updated schema for backwards compatibility
5bb8176
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2024
@sambodeme
Adding workbook version to sac records (#4377)
dc4958d 
* Added version to sac meta

* #4376 Updated logic to capture schema version in SAC record

* #4376 Updated schema for backwards compatibility
@sambodeme sambodeme moved this from In Progress to Done in FAC Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambodeme sambodeme

Labels
eng
Projects
FAC
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danswick @sambodeme